-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support new MLS cipher suite [WPB-8592] #2716
Conversation
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
18742df
to
bbf74b1
Compare
…le-4.6' into feat/WPB-8592
...ography/src/androidInstrumentedTest/kotlin/com/wire/kalium/cryptography/BaseMLSClientTest.kt
Outdated
Show resolved
Hide resolved
cryptography/src/commonJvmAndroid/kotlin/com.wire.kalium.cryptography/CoreCryptoCentral.kt
Show resolved
Hide resolved
cryptography/src/commonTest/kotlin/com/wire/kalium/cryptography/E2EIClientTest.kt
Outdated
Show resolved
Hide resolved
cryptography/src/commonTest/kotlin/com/wire/kalium/cryptography/MLSClientTest.kt
Outdated
Show resolved
Hide resolved
logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/mlsmigration/MLSMigrationWorker.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, added some suggestion and spotted one forgotten TODO?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note you need to:
- Provide the matching external sender for the cipher-suite when creating new MLS group
Upload the matching public key with the right name when registering an MLS client
Maybe I missed it but I don't see that being done in this PR.
this is done here #2720 |
Cool, what about the external senders when creating a group? |
t is already included |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Solutions
parse and store the default cipher suite info from the server and use it to start the MLS client
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.