Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support new MLS cipher suite [WPB-8592] #2716

Merged
merged 12 commits into from
Apr 30, 2024

Conversation

MohamadJaara
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

  1. a new MLS cipher suite need to be supported
  2. the info about the cipher suite if customizable by the backend

Solutions

parse and store the default cipher suite info from the server and use it to start the MLS client

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Apr 25, 2024

Test Results

2 851 tests   2 833 ✔️  4m 57s ⏱️
       7 suites       18 💤
       7 files           0

Results for commit d3068b0.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Apr 25, 2024

Datadog Report

All test runs 2f74c4c 🔗

2 Total Test Services: 0 Failed, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Test Service View
kalium-ios 0 0 0 2739 122 7m 8.09s Link
kalium-jvm 0 0 0 2879 106 8m 50.04s Link

@MohamadJaara MohamadJaara changed the base branch from release/candidate to release/android-cycle-4.6 April 29, 2024 11:16
@MohamadJaara MohamadJaara marked this pull request as ready for review April 29, 2024 20:04
Copy link
Member

@mchenani mchenani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added some suggestion and spotted one forgotten TODO?

Copy link
Member

@typfel typfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note you need to:

  • Provide the matching external sender for the cipher-suite when creating new MLS group
  • Upload the matching public key with the right name when registering an MLS client

Maybe I missed it but I don't see that being done in this PR.

@MohamadJaara
Copy link
Member Author

MohamadJaara commented Apr 30, 2024

Upload the matching public key with the right name when registering an MLS client

this is done here #2720

@typfel
Copy link
Member

typfel commented Apr 30, 2024

Upload the matching public key with the right name when registering an MLS client

this is done here #2720

Cool, what about the external senders when creating a group?

@MohamadJaara
Copy link
Member Author

Upload the matching public key with the right name when registering an MLS client

this is done here #2720

Cool, what about the external senders when creating a group?

t is already included
https://github.com/wireapp/kalium/pull/2716/files#diff-7ff2f388e622ca17f7b1a9be76851c4ae48fe928ccce10419932b3536eabcb56R110

@MohamadJaara MohamadJaara enabled auto-merge (squash) April 30, 2024 16:03
@MohamadJaara MohamadJaara merged commit 42db070 into release/android-cycle-4.6 Apr 30, 2024
17 checks passed
@MohamadJaara MohamadJaara deleted the feat/WPB-8592 branch April 30, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants