-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: persisting team members connection state (RC) [WPB-5338] #2191
fix: persisting team members connection state (RC) [WPB-5338] #2191
Conversation
persistence/src/commonMain/db_user/com/wire/kalium/persistence/Users.sq
Outdated
Show resolved
Hide resolved
We can cover |
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
Codecov Report
@@ Coverage Diff @@
## release/candidate #2191 +/- ##
====================================================
Coverage ? 58.18%
Complexity ? 21
====================================================
Files ? 1010
Lines ? 37731
Branches ? 3434
====================================================
Hits ? 21952
Misses ? 14313
Partials ? 1466 Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
Just one detail that can save us time in the future.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
After fresh login, if user already has some conversations with other team members, when opening other conversation member profile, the app shows “connect” button so the user appears as not connected, but this user is from the same team.
Solutions
Update also connection status for team members.
According to the documentation for the
upsertTeamMembers
function:so it looks like an oversight and it should also update connection status.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.