Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: persisting team members connection state (RC) [WPB-5338] #2191

Merged
merged 5 commits into from
Nov 6, 2023

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Nov 3, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

After fresh login, if user already has some conversations with other team members, when opening other conversation member profile, the app shows “connect” button so the user appears as not connected, but this user is from the same team.

Solutions

Update also connection status for team members.

According to the documentation for the upsertTeamMembers function:

This will update all columns, except [UserEntity.userType]

so it looks like an oversight and it should also update connection status.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@vitorhugods
Copy link
Member

We can cover updateTeamMemberUser a test that makes sure that all important fields are properly updated when running the query.

Copy link
Contributor

github-actions bot commented Nov 3, 2023

Unit Test Results

   412 files     412 suites   20s ⏱️
2 265 tests 2 145 ✔️ 120 💤 0

Results for commit 65c03d3.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Nov 3, 2023

Datadog Report

All test runs 0f776f5 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 2145 120 7m 58s Link
kalium-jvm 0 0 0 2262 98 6m 34.05s Link

@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release/candidate@5bee6d7). Click here to learn what that means.
The diff coverage is n/a.

@@                 Coverage Diff                  @@
##             release/candidate    #2191   +/-   ##
====================================================
  Coverage                     ?   58.18%           
  Complexity                   ?       21           
====================================================
  Files                        ?     1010           
  Lines                        ?    37731           
  Branches                     ?     3434           
====================================================
  Hits                         ?    21952           
  Misses                       ?    14313           
  Partials                     ?     1466           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bee6d7...65c03d3. Read the comment docs.

@saleniuk saleniuk requested review from a team, gongracr, borichellow, MohamadJaara and mchenani and removed request for a team and gongracr November 6, 2023 08:47
Copy link
Member

@vitorhugods vitorhugods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Just one detail that can save us time in the future.

@saleniuk saleniuk merged commit d77445c into release/candidate Nov 6, 2023
14 checks passed
@saleniuk saleniuk deleted the fix/team_members_connection_state_rc branch November 6, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants