Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: persist searched team members [WPB-5262] #2179

Merged

Conversation

saleniuk
Copy link
Contributor


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When user belongs to a huge team (over 2000 members), then all team members are not fetched and stored during the slow sync and because of that, when searching, the app can't filter out the team members from the public search list and doesn't know the connection status of them.

Solutions

When handling public search results, extract team members from the result and persist them locally as contacts.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Oct 31, 2023

Unit Test Results

   431 files     431 suites   2m 20s ⏱️
2 358 tests 2 260 ✔️ 98 💤 0

Results for commit 476b520.

♻️ This comment has been updated with latest results.

@saleniuk saleniuk requested review from vitorhugods, a team, typfel, gongracr, borichellow and Garzas and removed request for a team October 31, 2023 15:20
Copy link
Member

@vitorhugods vitorhugods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 😎

@saleniuk saleniuk requested review from tmspzz and removed request for gongracr October 31, 2023 15:50
@saleniuk saleniuk enabled auto-merge (squash) October 31, 2023 16:28
@saleniuk saleniuk merged commit 0df069c into release/candidate Nov 1, 2023
15 checks passed
@saleniuk saleniuk deleted the fix/search_team_members_connection_status branch November 1, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants