Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace NewClientEventData with ClientDTO #1804

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

typfel
Copy link
Member

@typfel typfel commented Jun 16, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

NewClientEventData duplicates ClientResponse since they are represented by same underlaying type.

Solutions

Delete NewClientEventData and replace it with ClientDTO (renamed from ClientResponse) and we can also remove some repeating mapping code due to this.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 16, 2023

Unit Test Results

   374 files  ±0     374 suites  ±0   2m 0s ⏱️ +40s
1 991 tests ±0  1 909 ✔️ ±0  82 💤 ±0  0 ±0 

Results for commit 47c32c3. ± Comparison against base commit ed3bdbb.

♻️ This comment has been updated with latest results.

@@ -23,7 +23,7 @@ import kotlinx.serialization.SerialName
import kotlinx.serialization.Serializable

@Serializable
data class ClientResponse(
data class ClientDTO(
Copy link
Member

@MohamadJaara MohamadJaara Jun 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the new client event also include ?

    @SerialName("mls_public_keys") val mlsPublicKeys: Map<String, String>?

Copy link
Member Author

@typfel typfel Jun 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but it's always empty because the mls keys are always added after a client has been created currently.

Copy link
Member

@MohamadJaara MohamadJaara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@typfel typfel added this pull request to the merge queue Jun 19, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 19, 2023
@typfel typfel added this pull request to the merge queue Jun 19, 2023
Merged via the queue into develop with commit 11e52e7 Jun 19, 2023
@typfel typfel deleted the refactor/simplify-client-dtos branch June 19, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants