-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace NewClientEventData with ClientDTO #1804
Conversation
@@ -23,7 +23,7 @@ import kotlinx.serialization.SerialName | |||
import kotlinx.serialization.Serializable | |||
|
|||
@Serializable | |||
data class ClientResponse( | |||
data class ClientDTO( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does the new client event also include ?
@SerialName("mls_public_keys") val mlsPublicKeys: Map<String, String>?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but it's always empty because the mls keys are always added after a client has been created currently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
NewClientEventData
duplicatesClientResponse
since they are represented by same underlaying type.Solutions
Delete
NewClientEventData
and replace it withClientDTO
(renamed from ClientResponse) and we can also remove some repeating mapping code due to this.PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.