fix: exclude self deleting messages from backup #1801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
🚨 Potential breaking changes
type: bug / fix 🐞
👕 size: M
and removed
Fix PR Title 🤦♂️
🚨 Potential breaking changes
labels
tmspzz
approved these changes
Jun 13, 2023
Codecov Report
@@ Coverage Diff @@
## develop #1801 +/- ##
=============================================
- Coverage 53.50% 53.48% -0.02%
Complexity 1525 1525
=============================================
Files 965 965
Lines 35854 35872 +18
Branches 3172 3176 +4
=============================================
+ Hits 19182 19186 +4
- Misses 15407 15421 +14
Partials 1265 1265 |
vitorhugods
requested changes
Jun 13, 2023
MohamadJaara
force-pushed
the
fix/exclude_self_deleting_messages_from_bckup
branch
from
901284b
to
7ebb981
Compare
and fix issue with delete old DB function
MohamadJaara
force-pushed
the
fix/exclude_self_deleting_messages_from_bckup
branch
from
58d1726
to
6e63aaf
Compare
…eleting_messages_from_bckup # Conflicts: # persistence/src/commonMain/db_user/migrations/42.sqm
vitorhugods
approved these changes
Jun 20, 2023
persistence/src/commonTest/kotlin/com/wire/kalium/persistence/backup/DatabaseExporterTest.kt
Outdated
Show resolved
Hide resolved
persistence/src/commonTest/kotlin/com/wire/kalium/persistence/backup/DatabaseExporterTest.kt
Outdated
Show resolved
Hide resolved
persistence/src/commonTest/kotlin/com/wire/kalium/persistence/BaseDatabaseTest.kt
Show resolved
Hide resolved
…BaseDatabaseTest.kt Co-authored-by: Vitor Hugo Schwaab <[email protected]>
…backup/DatabaseExporterTest.kt Co-authored-by: Vitor Hugo Schwaab <[email protected]>
…backup/DatabaseExporterTest.kt Co-authored-by: Vitor Hugo Schwaab <[email protected]>
github-actions
bot
added
👕 size: XXL
👕 size: XL
and removed
👕 size: XL
👕 size: XXL
labels
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
MohamadJaara
added a commit
that referenced
this pull request
Jun 20, 2023
* dump Reactions and receipt * revert change to ClearConversationContent * unit test * add index for message message_expire_after_millis_index * validate backup before and after and fix issue with delete old DB function * revert changes to enqueuePendingSelfDeletionMessages * detekt * nuke db test * fix jvm test * fix android test * merge conflicts * Update persistence/src/commonTest/kotlin/com/wire/kalium/persistence/BaseDatabaseTest.kt Co-authored-by: Vitor Hugo Schwaab <[email protected]> * Update persistence/src/commonTest/kotlin/com/wire/kalium/persistence/backup/DatabaseExporterTest.kt Co-authored-by: Vitor Hugo Schwaab <[email protected]> * Update persistence/src/commonTest/kotlin/com/wire/kalium/persistence/backup/DatabaseExporterTest.kt Co-authored-by: Vitor Hugo Schwaab <[email protected]> * trigger CI --------- Co-authored-by: Vitor Hugo Schwaab <[email protected]>
MohamadJaara
added a commit
that referenced
this pull request
Jun 21, 2023
* dump Reactions and receipt * revert change to ClearConversationContent * unit test * add index for message message_expire_after_millis_index * validate backup before and after and fix issue with delete old DB function * revert changes to enqueuePendingSelfDeletionMessages * detekt * nuke db test * fix jvm test * fix android test * merge conflicts * Update persistence/src/commonTest/kotlin/com/wire/kalium/persistence/BaseDatabaseTest.kt * Update persistence/src/commonTest/kotlin/com/wire/kalium/persistence/backup/DatabaseExporterTest.kt * Update persistence/src/commonTest/kotlin/com/wire/kalium/persistence/backup/DatabaseExporterTest.kt * trigger CI --------- Co-authored-by: Vitor Hugo Schwaab <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
self deleting messages are included in backups
Causes (Optional)
case not handled
Solutions
do not copy messages and related data when the message is self delete
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.