refactor: user mapper #1795
Merged
refactor: user mapper #1795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typfel
requested review from
Garzas,
yamilmedina and
trOnk12
and removed request for
Garzas and
yamilmedina
github-actions
bot
added
🚨 Potential breaking changes
👕 size: L
type: refactoring 🛠
labels
Codecov Report
@@ Coverage Diff @@
## develop #1795 +/- ##
=============================================
- Coverage 53.53% 53.48% -0.05%
+ Complexity 1514 1511 -3
=============================================
Files 960 960
Lines 35763 35740 -23
Branches 3171 3164 -7
=============================================
- Hits 19144 19114 -30
- Misses 15343 15366 +23
+ Partials 1276 1260 -16 |
vitorhugods
reviewed
Jun 13, 2023
Comment on lines
41
to
55
| // @Test | ||
| // fun givenUserProfileDTOAndUserTypeEntity_whenMappingFromApiResponse_thenDaoModelIsReturned() = runTest { | ||
| // // Given | ||
| // val givenResponse = TestUser.USER_PROFILE_DTO | ||
| // val givenUserTypeEntity = UserTypeEntity.EXTERNAL | ||
| // val expectedResult = TestUser.ENTITY.copy( | ||
| // phone = null, // UserProfileDTO doesn't contain the phone | ||
| // connectionStatus = ConnectionEntity.State.NOT_CONNECTED // UserProfileDTO doesn't contain the connection status | ||
| // ) | ||
| // val (_, userMapper) = Arrangement().arrange() | ||
| // // When | ||
| // val result = userMapper.fromApiModelWithUserTypeEntityToDaoModel(givenResponse, givenUserTypeEntity) | ||
| // // Then | ||
| // assertEquals(expectedResult, result) | ||
| // } |
There was a problem hiding this comment.
I forgot to delete it after deleting this mapping function.
There was a problem hiding this comment.
Decided to resurrect it since test coverage of the other function was completely missing.
Garzas
reviewed
Jun 13, 2023
We've agreed to do it like that for all mappers going forward? I'm not doing it in this PR though, it would be a follow up PR then. |
Garzas
approved these changes
Jun 13, 2023
vitorhugods
approved these changes
Jun 16, 2023
logic/src/commonMain/kotlin/com/wire/kalium/logic/data/user/UserRepository.kt
Outdated
Show resolved
Hide resolved
logic/src/commonMain/kotlin/com/wire/kalium/logic/data/user/UserRepository.kt
Outdated
Show resolved
Hide resolved
yamilmedina
approved these changes
Jun 16, 2023
Co-authored-by: Vitor Hugo Schwaab <[email protected]>
Co-authored-by: Vitor Hugo Schwaab <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Solutions
Notes
Should we merge PublicUserMapping and UserMapping into one?
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.