feat: sso loging with email [WPB-255] #1793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: use case for user domain lookup * SpacingAroundParens * expose domain lookup use case * feat: domain look up in sso login screen * detekt
* feat: fetch sso settings use case * add unit test * docs * map 404 error to success with no code * remove magic number
github-actions
bot
added
🚨 Potential breaking changes
👕 size: XL
type: feature ✨
labels
typfel
approved these changes
Jun 12, 2023
Codecov Report
@@ Coverage Diff @@
## develop #1793 +/- ##
=============================================
- Coverage 53.49% 53.49% -0.01%
- Complexity 1525 1533 +8
=============================================
Files 965 973 +8
Lines 35844 35904 +60
Branches 3171 3176 +5
=============================================
+ Hits 19174 19206 +32
- Misses 15404 15429 +25
- Partials 1266 1269 +3 |
saleniuk
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
logic and use cases needed for SSO login with email WPB-255
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.