Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: register new client if local crypto files are missing #1726

Merged
merged 4 commits into from
Jun 16, 2023

Conversation

MohamadJaara
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

in some very rare cases (it happened only 2 times) the app will have a client id, but local crypto files are missing

Causes (Optional)

Unknown, I was able to reproduce the same stack trace by manually deleting the files

Solutions

change NeedsToRegisterClientUseCase to return true if local files are missing

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented May 11, 2023

Unit Test Results

   271 files   - 103     271 suites   - 103   8s ⏱️ - 1m 43s
1 372 tests  - 618  1 341 ✔️  - 567  31 💤  - 51  0 ±0 

Results for commit 1f45b7c. ± Comparison against base commit ff57c9e.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented May 15, 2023

Codecov Report

Merging #1726 (0378401) into develop (a2009fd) will increase coverage by 0.00%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##             develop    #1726   +/-   ##
==========================================
  Coverage      53.20%   53.21%           
  Complexity      1513     1513           
==========================================
  Files            948      948           
  Lines          34833    34838    +5     
  Branches        3043     3043           
==========================================
+ Hits           18534    18539    +5     
  Misses         15073    15073           
  Partials        1226     1226           

@typfel typfel enabled auto-merge June 16, 2023 09:21
@typfel typfel added this pull request to the merge queue Jun 16, 2023
Merged via the queue into develop with commit 36a0f05 Jun 16, 2023
9 checks passed
@typfel typfel deleted the fix/register_new_client_if_local_files_are_missing branch June 16, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants