Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(federation): offline backends handling (epic) #1548

Merged
merged 54 commits into from
Jun 23, 2023

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Mar 2, 2023

REOPENING FOR TRACK -ALREADY APPROVED PR- WILL MERGE LATER.
#1531


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

This is the epic branch of previous merged PRs:

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2023

Unit Test Results

   355 files     355 suites   17s ⏱️
1 889 tests 1 811 ✔️ 78 💤 0

Results for commit 2096232.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2023

Codecov Report

Merging #1548 (2096232) into develop (26bd923) will increase coverage by 0.75%.
The diff coverage is 74.50%.

@@              Coverage Diff              @@
##             develop    #1548      +/-   ##
=============================================
+ Coverage      53.47%   54.22%   +0.75%     
- Complexity      1525     1550      +25     
=============================================
  Files            965      973       +8     
  Lines          35872    36439     +567     
  Branches        3176     3233      +57     
=============================================
+ Hits           19181    19760     +579     
+ Misses         15425    15368      -57     
- Partials        1266     1311      +45     

@yamilmedina yamilmedina force-pushed the feat/epic-federation-offline-messages branch from af58833 to 922351d Compare March 27, 2023 07:36
@yamilmedina yamilmedina force-pushed the feat/epic-federation-offline-messages branch from 922351d to cea803a Compare March 27, 2023 07:39
@yamilmedina yamilmedina force-pushed the feat/epic-federation-offline-messages branch from c9af0c8 to eac76fd Compare April 3, 2023 16:35
yamilmedina and others added 6 commits June 7, 2023 09:24
* feat: add new response handling create convo v4

* feat: add new response handling create convo v4 test

* feat: add new response handling create convo v4 test

* feat: add tests cases and persitence of msg for failed to add

* feat: add tests cases and persitence of msg for failed to add

---------

Co-authored-by: Mohamad Jaara <[email protected]>
@yamilmedina yamilmedina marked this pull request as ready for review June 22, 2023 14:26
@yamilmedina yamilmedina changed the title feat: epic - federation, offline backends message sending (AR-3015) feat(federation): epic - offline backends handling (AR-3015) Jun 23, 2023
@yamilmedina yamilmedina changed the title feat(federation): epic - offline backends handling (AR-3015) feat(federation): offline backends handling (epic) Jun 23, 2023
@tmspzz tmspzz enabled auto-merge June 23, 2023 11:05
@tmspzz tmspzz added this pull request to the merge queue Jun 23, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 23, 2023
@yamilmedina yamilmedina added this pull request to the merge queue Jun 23, 2023
Merged via the queue into develop with commit 8cae138 Jun 23, 2023
@yamilmedina yamilmedina deleted the feat/epic-federation-offline-messages branch June 23, 2023 12:22
@Garzas Garzas restored the feat/epic-federation-offline-messages branch June 27, 2023 08:43
@Garzas Garzas deleted the feat/epic-federation-offline-messages branch June 27, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants