-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use native disk methods instead of the pseudo scoped disks #844
base: develop
Are you sure you want to change the base?
Conversation
…isks" defined in the cms config
|
@jaxwilko this was the WIP PR for breaking out those disks, I don't think it would be too difficult to finish. Perhaps we should also use properties instead of class constants for storing the disks so that we can more easily switch away from the singleton pattern later for the medialibrary etc. Do you want to take a look and see what's left to push it across the finish line? |
@LukeTowers Happy to do so but it's going to be middle of next week before i can start :) |
WIP, requires wintercms/storm#141