Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing wrapper logs #485

Merged
merged 1 commit into from
Jul 23, 2020
Merged

Fix missing wrapper logs #485

merged 1 commit into from
Jul 23, 2020

Conversation

nxtn
Copy link
Contributor

@nxtn nxtn commented Apr 7, 2020 •
edited
Loading

No description provided.

@nxtn nxtn added the bug label Apr 7, 2020
@nxtn nxtn added this to the 2.Next milestone Apr 7, 2020
@nxtn nxtn requested a review from oleg-nenashev as a code owner April 7, 2020 00:45
@oleg-nenashev
Copy link
Member

I need to investigate that a bit. Call duplication was deliberate when I was moving logging to log4net, but I do not recall what was the reason. Not sure this is still actual

@oleg-nenashev oleg-nenashev self-assigned this Apr 8, 2020
@nxtn nxtn mentioned this pull request Apr 11, 2020
Closed
@nxtn nxtn marked this pull request as draft April 13, 2020 07:28
@nxtn
Copy link
Contributor Author

nxtn commented Apr 13, 2020

Call duplication was deliberate when I was moving logging to log4net, but I do not recall what was the reason.

I see. It must be due to the log level.

winsw/src/Core/ServiceWrapper/Main.cs

Line 885 in 31af6fe

Level eventLogLevel = Level.Warn;

@nxtn nxtn changed the base branch from master to v3 July 23, 2020 11:17
@nxtn nxtn marked this pull request as ready for review July 23, 2020 11:18
@nxtn nxtn modified the milestones: 2.x, 3.x Jul 23, 2020
@nxtn nxtn merged commit 048e8e5 into winsw:v3 Jul 23, 2020
@nxtn nxtn deleted the logevent branch July 23, 2020 11:23
@nxtn nxtn changed the title Redirect event logging Remove duplicated warning/error log entries Jul 23, 2020
@nxtn nxtn changed the title Remove duplicated warning/error log entries Fix missing wrapper logs Jul 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev Awaiting requested review from oleg-nenashev oleg-nenashev is a code owner

Assignees

@oleg-nenashev oleg-nenashev

Labels
bug
Projects
None yet
Milestone
3.x
Development

Successfully merging this pull request may close these issues.
2 participants
@nxtn @oleg-nenashev