Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "duration" in "durationMs", remove unit. #380

Closed
wants to merge 1 commit into from
Closed

Rename "duration" in "durationMs", remove unit. #380

wants to merge 1 commit into from

Conversation

gregberge
Copy link
Contributor

String field is not usable in log analyzer tools like ES + Kibana.

Fix #373.

@gregberge gregberge closed this Jun 6, 2014
@indexzero indexzero reopened this Dec 16, 2014
@indexzero
Copy link
Member

👍, but this is a breaking change so will go out in v1.0.0

@gregberge
Copy link
Contributor Author

Don't be afraid by major :)

@indexzero
Copy link
Member

Thanks! Cherry-picked. Will go into [email protected] which should be published shortly.

@indexzero indexzero closed this Apr 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use "duration-ms" instead of "duration"
2 participants
@gregberge @indexzero