Fix logging when level is set on the logger, but no level is set on tranports #253
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example code:
Expected output:
Actual output:
Reason: transport.js sets a default level of 'Info' when no level option is set on a transport. logger.js always uses the transport level (when set) instead of using the level set on the logger. Since a level is always set on every transport, the logger's level is never used.
I changed transport.js so that it does not set a default value for this.level. This fixes the issue.