Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update documentation for #2114 #2138

Merged
merged 5 commits into from
May 26, 2022
Merged

update documentation for #2114 #2138

merged 5 commits into from
May 26, 2022

Conversation

zizifn
Copy link
Contributor

@zizifn zizifn commented May 25, 2022

As adding the console transport into the default logger may be a breaking change for some setups, so add documentation for point out the issue.

@zizifn
Copy link
Contributor Author

zizifn commented May 25, 2022

@wbt Please take a look at the documentation update for #2114 and closed PR #2134

@wbt
Copy link
Contributor

wbt commented May 25, 2022

I've made some changes to the PR. @zizifn if the new version of the PR looks good to you we can merge it in.

@zizifn
Copy link
Contributor Author

zizifn commented May 25, 2022

I've made some changes to the PR. @zizifn if the new version of the PR looks good to you we can merge it in.

@wbt Thanks! Looks good! We can merge it.

@wbt wbt merged commit 222c863 into winstonjs:master May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants