Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Profiler constructor has no guardrails for what it's constructed from #2091

Closed
maverick1872 opened this issue Mar 15, 2022 · 0 comments · Fixed by #2226
Closed

[Bug]: Profiler constructor has no guardrails for what it's constructed from #2091

maverick1872 opened this issue Mar 15, 2022 · 0 comments · Fixed by #2226
Labels
Bug Groomed Issue has been reviewed and is ready for handling Help Wanted Additional help desired from the community Important Needs Investigation

Comments

@maverick1872
Copy link
Member

🔎 Search Terms

Profiler, constructor

The problem

The constructor for our Profiler has no guardrails for what it considers to be a valid argument to construct a Profiler from. As such there is the potential for this being used incorrectly. As such we should add some guardrails to this to ensure it's leveraged correctly in all situations.

What version of Winston presents the issue?

latest

What version of Node are you using?

v16

If this worked in a previous version of Winston, which was it?

No response

Minimum Working Example

No response

Additional information

Original discussion regarding the issue:
#1989 (comment)
@maverick1872 maverick1872 added Needs Investigation Bug Important Help Wanted Additional help desired from the community Groomed Issue has been reviewed and is ready for handling labels Mar 15, 2022
@maverick1872 maverick1872 mentioned this issue Mar 15, 2022
Merged
debadutta98 added a commit to debadutta98/winston that referenced this issue Oct 29, 2022
@debadutta98
fix winstonjs#2091
757fc13
@debadutta98 debadutta98 mentioned this issue Oct 29, 2022
Merged
debadutta98 added a commit to debadutta98/winston that referenced this issue Nov 4, 2022
@debadutta98
Merge branch 'winstonjs:master' into fix-winstonjs#2091
eb44e68
debadutta98 added a commit to debadutta98/winston that referenced this issue Jun 14, 2023
@debadutta98
Merge branch 'winstonjs:master' into fix-winstonjs#2091
ec738ba
debadutta98 added a commit to debadutta98/winston that referenced this issue Jun 29, 2023
@debadutta98
Merge branch 'winstonjs:master' into fix-winstonjs#2091
9eb31d8
debadutta98 added a commit to debadutta98/winston that referenced this issue Jul 31, 2023
@debadutta98
Merge branch 'winstonjs:master' into fix-winstonjs#2091
03ad089
debadutta98 added a commit to debadutta98/winston that referenced this issue Jul 31, 2023
@debadutta98
Merge branch 'winstonjs:master' into fix-winstonjs#2091
7267edb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Groomed Issue has been reviewed and is ready for handling Help Wanted Additional help desired from the community Important Needs Investigation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add guardrails to Profiler class debadutta98/winston
1 participant
@maverick1872