Don't force english language #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "\n google.load('visualization', '#{version}', {packages: ['#{package_name}'], language: '#{language}', callback: #{chart_function_name(element_id)}});" | ||
| language_opt = ", language: '#{language}'" if language | ||
|
|
||
| "\n google.load('visualization', '#{version}', {packages: ['#{package_name}']#{language_opt}, callback: #{chart_function_name(element_id)}});" |
There was a problem hiding this comment.
Inconsistent indentation detected.
From the docs: „By default, the Google Chart libraries are loaded with the locale specified by the browser“.
ledermann
force-pushed
the
dont-force-english-language
branch
from
5a73f26 to
e421285
Compare
|
Good catch! My bad! Merging and releasing a new patch. Thanks! 🙇 |
|
New version up on https://rubygems.org/gems/google_visualr |
|
Wow, this was fast - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #96, the
languageoption was introduced. Unfortunately, it forces the language to be english, if the option is not set. This breaks the browser detection. Please see the docs:This PR removes the fallback