Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add new charts #97

Merged
merged 2 commits into from
Aug 27, 2015
Merged

Feature/add new charts #97

merged 2 commits into from
Aug 27, 2015

Conversation

winston
Copy link
Owner

@winston winston commented Aug 27, 2015

Add new charts:

These are not added:

  • Diff Chart - This is not easy for now. Out of scope at the moment.
  • Donut Chart - This is just a PieChart with special options.
  • Intervals - This is just a LineChart with special options.
  • Trendlines - This is just a ScatterChart with special options.
  • Waterfall Chart - This is just an AreaChart with special options.

Fixes #83

winston added 2 commits August 27, 2015 17:01
@winston
Add new charts:
a1c011a 
- annotation chart
- calendar
- gantt
- sankey
- word tree
@winston
Reorder requires.
308d08c
houndci-bot
houndci-bot reviewed Aug 27, 2015
View reviewed changes
lib/google_visualr/interactive/word_tree.rb
# For Configuration Options, please refer to:
# https://developers.google.com/chart/interactive/docs/gallery/wordtree#a-simple-example
end

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra empty line detected at module body end.

winston added a commit that referenced this pull request Aug 27, 2015
@winston
Merge pull request #97 from winston/feature/add-new-charts
90474f9 
Feature/add new charts
@winston winston merged commit 90474f9 into feature/add-locale Aug 27, 2015
@winston winston deleted the feature/add-new-charts branch August 27, 2015 15:23
@winston winston mentioned this pull request Aug 27, 2015
Closed
@TomNaessens
Copy link

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@winston @TomNaessens @houndci-bot