Update lib/google_visualr/base_chart.rb #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The event registration happens after the `draw` call. Because of this `ready` events are never triggered. Changed the order of event registration and `draw` call to address this issue.
|
Thanks for the pull request! Can you help to fix the failing test too? Thank you! |
|
Fixed the spec and submitted a new pull request #48 |
winston
added a commit
that referenced
this pull request
Oct 30, 2012
Fixed the spec for failing test in pull #47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The event registration happens after the
drawcall. Because of thisreadyevents are never triggered.Changed the order of event registration and
drawcall to address this issue.