Skip to content

Added support for Stepped Area Chart #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 30, 2012
Merged

Added support for Stepped Area Chart #37

merged 2 commits into from
Jul 30, 2012

Conversation

kacperk
Copy link
Contributor

@kacperk kacperk commented Jul 30, 2012

Added Stepped Area Chart. I will be very pleased if you can merge this changes to main gem.

@winston
Copy link
Owner

winston commented Jul 30, 2012

Thanks for this! 2 comments though:

  1. Since the classname is SteppedAreaChart, the filename should be stepped_area_chart
  2. Can you also update the comments on Line 4 and 9?

Once these are done, I'll need to put in doc for googlevisualr.heroku.com before I bump the version of the gem. Thank you.

@kacperk
Copy link
Contributor Author

kacperk commented Jul 30, 2012

Done.

winston added a commit that referenced this pull request Jul 30, 2012
Added support for Stepped Area Chart
@winston winston merged commit 8590229 into winston:master Jul 30, 2012
@winston
Copy link
Owner

winston commented Jul 30, 2012

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants