-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Object Manager Plus #2197
Object Manager Plus #2197
Conversation
- Standard System Informer handle properties window for Windows objects (including Directories). - Add support for missing object types: Device, EventPair, Timer, Semaphore, FilterConnectionPort - Add target link info for Symbolic links - Fix Directory handles leaking
- Add Windows Object tab to properties window: object attributes and creation time. - Add GeneralCallbackHandlePropertiesWindowPreOpen, calls on WM_INITDIALOG and allows plugins to customize general handle properties tab. -- Display real handles count and hide irrelevant access entry (EtHandlePropertiesWindowPreOpen). - Add Symbolic Link Target column - Enhanced navigation to symlink: focus to target in ListView.
- Implements search using standard SI searchbox: searches all 3 columns (name, type, symlink) - Status bar (pseudo) with fullpath to selected object (can copy on righclick menu), current directory object count - Refresh button - full rebuild of tree and current dir list - Get object address using KSI (previous commit)
- I finally understand how PH memory management works and fixed (hope) horrible previous code. - Fixed WM_KEYDOWN forwarding (both for PH and plugins), broken by 5bf7f29 - F5 - refresh, filter will be reapplied after refresh - Autosizing of Name column on window resizing. Plugin properties window position will not overwrite generic handle propertines window position setting.
Awesome work! I'll help give an in-depth review when I have some cycles. Some initial feedback on the video you provided (thanks for that it's very helpful). I wonder if it makes sense to change the "Symbolic Link Target" column to a more generic "Target" column to show information/names of things more broadly? I'm thinking, for example, you could show the name for named object or the device for filter ports. Instead of only showing symbol link names. |
Broken by 0c0c938
- Renamed Symbolic Link Target column to Target - Implemented (experimental) asynchronous resolver for Device and ALPC port targets. -- Resolving Device driver target. Added menu Go to device driver -- Resolving ALPC server process target. Added menu Go to server process - Rewritten navigaton to symbolic links (and device drivers)
Add target resolving for Device and ALPC port
Add target resolving for Mutant, fix search resolver_test.mp4 |
- Improve resolver. Added mutant client owner to target and menu Go to thread... - Improve filter: it now stay when changing directory. If selected entry match it stay selected and visible when performing search. - Tri-state column sort now saved and loaded from settings (ObjectManagerWindowListSort). Sort now works correctly on directory or filter change. - Enter - open properties, Shift+Enter - open security, Shift+Dblclk on symlink opens its properties.
baaf60c
to
678539e
Compare
- Fix SymbolicLink target in handle properties
678539e
to
17ba73e
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
- Object Handles tab: added support for changing handle attributes - ET plugin extensions now available for Driver, Device, Type (globally for any handle properties windows)
850f2ac
to
318dbab
Compare
c5f930f
to
1fae386
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more things @DartVanya. I think we're very close to being able to merge 🚀 .
There is some formatting and style nits that I opted not to comment on. Mostly function close parenthesis is not correctly indented or mics style things here and there. I don't mind going to clean those up myself after merging. 👍
97dc38d
to
9c589e6
Compare
- Extract information from more kernel objects using new method (ex. \PowerPort, \Win32kCrossSessionGlobals) - Retrieve extra object attributes from OBJECT_HEADER.Flags via driver - Show additional Driver info: Service Name, Size, Start Address, Flags
9c589e6
to
bfcab09
Compare
@@ -877,35 +2397,53 @@ INT_PTR CALLBACK WinObjDlgProc( | |||
EtObjectManagerRootDirectoryObject | |||
); | |||
|
|||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could removed this by mistake since many things were rewritten and added. I will look into and try to revert this and commit to #2284.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DartVanya please use a different PR. Try to break up your changes into more consumable/reviewable PRs, please ❤️. Because, I don't immediately see how restoring this functionality is directly related to the PR you linked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jxy-s Sorry, we talk about it before, and I already did same mistake again 😥
I will rebase PR to unstack objmgr changes to different PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in 165f3a5
Implement properties support for Object Manager
Enhanced Object Manager
Defied WinObj: search, statusbar, refresh
[System Informer, Plugins] Fixed WM_KEYDOWN forwarding (both for PH and plugins), broken by 5bf7f29#diff-22c39c7de8c6ce2547b9cda41005993a982b12b5f4d567a14ce7e38534c2bf77L1789
Add target resolving for Device and ALPC port
Add target resolving for Mutant, fix search
Support for open symlink target in explorer
Show Job process list in target column
Add CpuPartition type support and icons for more types
New Object Handles page in properties
[phlib, kphlib] Add PhOpenDevice. And Oject Manager Plus FINAL
TreeNew: significantly improve visibility of selected item.
Support for multiple non-modal object properties windows
Add KphOpenObjectByTypeIndex