Skip to content

Roundtrip3: Refinements Based on Derek Buitenhuis' Comments #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
winlinvip merged 25 commits into from
Jun 9, 2023
Merged

Roundtrip3: Refinements Based on Derek Buitenhuis' Comments #4

winlinvip merged 25 commits into from
Jun 9, 2023

Conversation

@winlinvip
Copy link
Owner

@winlinvip winlinvip commented Jun 9, 2023

  1. Refine WHIP muxer name.
  2. Refine SRTP key macros.
  3. Refine logging context.
  4. Refine SSL error messages.
  5. Refine DTLS error messages.
  6. Refine RTC error messages.
  7. Use AV_RB8 to read integer from memory.
  8. Update DTLS curve list to X25519:P-256:P-384:P-521.
  9. Refine SRTP profile name for FFmpeg and OpenSSL.
  10. Replace magic numbers with macros and extract to functions.
  11. Alter log levels from INFO to VERBOSE, except for final results.
  12. Use typedef SRTPContext.
  13. Refine the ICE STUN magic number.
  14. Reposition the on_rtp_write_packet function.
  15. Refer to Chrome definition of RTP payload types.
  16. Replace magic numbers with macros for RTP and RTCP payload types.
  17. Rename to WHIP muxer.
  18. Add TODO for OPUS timestamp issue.
  19. Refine comments, do not hardcode H.264.
  20. Define SDP session id and creator IP as macros.
  21. Refine fixed frame size 960 to rtc->audio_par->frame_size.
  22. Use h264_mp4toannexb to convert MP4/ISOM to annexb.
  23. Address occasional inaccuracies in OPUS audio timestamps.
  24. Correct marker setting after utilizing BSF.
  25. Remove dependency on avc.h after using BSF.

winlinvip added 25 commits June 8, 2023 07:23
@winlinvip
WHIP: Refine name.
1098439
@winlinvip
WHIP: Refine SRTP key macros.
101ebd8
@winlinvip
WHIP: Refine logging context.
01a23e7
@winlinvip
WHIP: Refine SSL error messages
5cd5aff
@winlinvip
WHIP: Refine DTLS error messages.
ae9f28d
@winlinvip
WHIP: Refine RTC error messages.
881811e
@winlinvip
WHIP: Use AV_RB8 to read integer from memory.
2922d3c
@winlinvip
WHIP: Update DTLS curve list to X25519:P-256:P-384:P-521 according to…
91ae61f 
… WebRTC.
@winlinvip
WHIP: Refine SRTP profile name for FFmpeg and OpenSSL.
7e60968
@winlinvip
WHIP: Replace the magic number to a macro and extract to a function i…
bc0413b 
…s_dtls_packet.
@winlinvip
WHIP: Altered all log levels from INFO to VERBOSE, except for the fin…
70683db 
…al one, which gathers the time cost for each step.
@winlinvip
WHIP: Use typedef SRTPContext
004c995
@winlinvip
WHIP: Refine the ICE STUN magic number.
03f1ce0
@winlinvip
WHIP: Reposition the on_rtp_write_packet function slightly earlier in…
5aef9f7 
… the file to prevent the same file proto.
@winlinvip
WHIP: Referring to Chrome definition of RTP payload types.
b068d4d
@winlinvip
WHIP: Replace the magic number with a macro for both RTP and RTCP pay…
ac49d7d 
…load types.
@winlinvip
WHIP: Rename to WHIP muxer
93d5c42
@winlinvip
WHIP: Add TODO for OPUS timestamp issue.
9a67150
@winlinvip
WHIP: Refine comments, do not hardcode h.264
fd92e47
@winlinvip
WHIP: Define SDP session id and creator ip as macro.
2e7d345
@winlinvip
WHIP: Refine the fixed frame size 960 to rtc->audio_par->frame_size.
d866ac3
@winlinvip
WHIP: Use h264_mp4toannexb to convert MP4/ISOM to annexb.
6598ffc
@winlinvip
WHIP: Occasionally, the timestamp of OPUS audio may be inaccurate, pa…
961c95c 
…rticularly when the input is an MP4 file.
@winlinvip
WHIP: After utilizing BSF, the marker is correctly set to correct, re…
e459364 
…move NALU_TYPE_STAP_A.
@winlinvip
WHIP: After using BSF, there is no longer dependency on avc.h
a0823aa
@winlinvip winlinvip changed the title Roundtrip3: WHIP Muxer Refinements and Improvements Based on Derek Buitenhuis' Comments Roundtrip3: WHIP Muxer Refinements Based on Derek Buitenhuis' Comments Jun 9, 2023
@winlinvip winlinvip changed the title Roundtrip3: WHIP Muxer Refinements Based on Derek Buitenhuis' Comments Roundtrip3: Refinements Based on Derek Buitenhuis' Comments Jun 9, 2023
@winlinvip winlinvip merged commit 4dae919 into feature/rtc-muxer Jun 9, 2023
winlinvip added a commit that referenced this pull request Oct 17, 2023
@winlinvip
Roundtrip3: Refinements Based on Derek Buitenhuis' Comments (#4)
680ed49 
1. Refine WHIP muxer name.
1. Refine SRTP key macros.
1. Refine logging context.
1. Refine SSL error messages.
1. Refine DTLS error messages.
1. Refine RTC error messages.
1. Use AV_RB8 to read integer from memory.
1. Update DTLS curve list to X25519:P-256:P-384:P-521.
1. Refine SRTP profile name for FFmpeg and OpenSSL.
1. Replace magic numbers with macros and extract to functions.
1. Alter log levels from INFO to VERBOSE, except for final results.
1. Use typedef SRTPContext.
1. Refine the ICE STUN magic number.
1. Reposition the on_rtp_write_packet function.
1. Refer to Chrome definition of RTP payload types.
1. Replace magic numbers with macros for RTP and RTCP payload types.
1. Rename to WHIP muxer.
1. Add TODO for OPUS timestamp issue.
1. Refine comments, do not hardcode H.264.
1. Define SDP session id and creator IP as macros.
1. Refine fixed frame size 960 to rtc->audio_par->frame_size.
1. Use h264_mp4toannexb to convert MP4/ISOM to annexb.
1. Address occasional inaccuracies in OPUS audio timestamps.
1. Correct marker setting after utilizing BSF.
1. Remove dependency on avc.h after using BSF.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@winlinvip