Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): aws lambda layers #6790

Merged
merged 8 commits into from
Jun 26, 2024
Merged

feat(sdk): aws lambda layers #6790

merged 8 commits into from
Jun 26, 2024

Conversation

Chriscbr
Copy link
Contributor

Closes #6761

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@Chriscbr Chriscbr requested a review from a team as a code owner June 26, 2024 02:31
Copy link

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistance, don't hesitate to ping the relevant owner over Discord.

Topic Owner
Wing SDK and utility APIs @chriscbr
Wing Console @ainvoner, @skyrpex, @polamoros
JSON, structs, primitives and collections @hasanaburayyan
Platforms and plugins @hasanaburayyan
Frontend resources (website, react, etc) @tsuf239
Language design @chriscbr
VSCode extension and language server @markmcculloh
Compiler architecture, inflights, lifting @yoav-steinberg
Wing Testing Framework @tsuf239
Wing CLI @markmcculloh
Build system, dev environment, releases @markmcculloh
Library Ecosystem @chriscbr
Documentation @hasanaburayyan
SDK test suite @tsuf239
Examples @hasanaburayyan
Wing Playground @eladcon

@monadabot
Copy link
Contributor

monadabot commented Jun 26, 2024

Console preview environment is available at https://wing-console-pr-6790.fly.dev 🚀

Last Updated (UTC) 2024-06-26 03:11

@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Jun 26, 2024
@monadabot
Copy link
Contributor

Benchmarks

Comparison to Baseline ⬜🟥⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜
Benchmark Before After Change
version 58ms±1.11 57ms±0.63 -1ms (-1.93%)⬜
jsii_small.test.w -t sim 376ms±5.66 394ms±14.68 +19ms (+4.94%)🟥
jsii_small.test.w -t tf-aws 614ms±2.7 631ms±8.43 +17ms (+2.73%)⬜
jsii_big.test.w -t sim 3041ms±30.07 3027ms±16.67 -14ms (-0.46%)⬜
jsii_big.test.w -t tf-aws 3251ms±17.83 3208ms±18.64 -43ms (-1.32%)⬜
functions_10.test.w -t sim 511ms±9.18 509ms±10 -2ms (-0.43%)⬜
functions_10.test.w -t tf-aws 2121ms±7.91 2099ms±14.16 -21ms (-1%)⬜
hello_world.test.w -t sim 407ms±7.04 404ms±5.53 -3ms (-0.82%)⬜
hello_world.test.w -t tf-aws 1479ms±16.02 1486ms±8.84 +7ms (+0.45%)⬜
empty.test.w -t sim 378ms±5.07 377ms±6.04 -2ms (-0.42%)⬜
empty.test.w -t tf-aws 601ms±4.56 616ms±6.7 +15ms (+2.49%)⬜
functions_1.test.w -t sim 413ms±4.93 414ms±4.63 +1ms (+0.21%)⬜
functions_1.test.w -t tf-aws 863ms±8.29 855ms±6.95 -7ms (-0.83%)⬜

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 57ms 56ms 59ms 1ms 1ms
jsii_small.test.w -t sim 394ms 361ms 436ms 15ms 21ms
jsii_small.test.w -t tf-aws 631ms 620ms 653ms 8ms 12ms
jsii_big.test.w -t sim 3027ms 3000ms 3072ms 17ms 23ms
jsii_big.test.w -t tf-aws 3208ms 3153ms 3237ms 19ms 26ms
functions_10.test.w -t sim 509ms 488ms 531ms 10ms 14ms
functions_10.test.w -t tf-aws 2099ms 2059ms 2115ms 14ms 20ms
hello_world.test.w -t sim 404ms 394ms 421ms 6ms 8ms
hello_world.test.w -t tf-aws 1486ms 1467ms 1500ms 9ms 12ms
empty.test.w -t sim 377ms 363ms 390ms 6ms 8ms
empty.test.w -t tf-aws 616ms 600ms 628ms 7ms 9ms
functions_1.test.w -t sim 414ms 405ms 424ms 5ms 6ms
functions_1.test.w -t tf-aws 855ms 839ms 872ms 7ms 10ms
Last Updated (UTC) 2024-06-26 02:52

@monadabot
Copy link
Contributor

❌ Unstable Self-Mutation ❌

Self-mutation has run twice in a row. There may be a something non-deterministic in the build or test process.
Check the last mutation commit (d531560) for suspicious changes.
This is typically caused by:

  • Absolute paths
  • Timestamps
  • Random values
  • Flakey tests (relying on one of the above)

@Chriscbr Chriscbr removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Jun 26, 2024
@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Jun 26, 2024
@Chriscbr Chriscbr removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Jun 26, 2024
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some documentation and example to function.md

Copy link
Contributor

mergify bot commented Jun 26, 2024

Thanks for contributing, @Chriscbr! This PR will now be added to the merge queue, or immediately merged if rybickic/lambda-layer is up-to-date with main and the queue is empty.

@mergify mergify bot merged commit 734a760 into main Jun 26, 2024
15 checks passed
@mergify mergify bot deleted the rybickic/lambda-layer branch June 26, 2024 10:26
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.75.12.

@Chriscbr
Copy link
Contributor Author

Oops - I added some docs but I added it to the wrong file so it ended up disappearing. Let me fix this up...

@Chriscbr Chriscbr mentioned this pull request Jun 26, 2024
5 tasks
mergify bot pushed a commit that referenced this pull request Jun 26, 2024
Add docs that were missing from #6790

## Checklist

- [x] Title matches [Winglang's style guide](https://www.winglang.io/contributing/start-here/pull_requests#how-are-pull-request-titles-formatted)
- [x] Description explains motivation and solution
- [ ] Tests added (always)
- [x] Docs updated (only required for features)
- [ ] Added `pr/e2e-full` label if this feature requires end-to-end testing

*By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support AWS Lambda layers
3 participants