Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature CSMT enable check box in winecfg #3

Closed
wants to merge 178 commits into from
Closed

Feature CSMT enable check box in winecfg #3

wants to merge 178 commits into from

Conversation

mrdeathjr28
Copy link
Contributor

Hi and thanks for your work

If can possible add csmt enable check box in winecfg, this can be usefull for testing like as wine-staging

Thanks

@stefand
wined3d: Merge get_pitch functions.
c43584d
@stefand
wined3d: Pass a context to surface_load_sysmem.
ee57416
@stefand
wined3d: Pass a context to read_from_framebuffer.
b31578c 
In the average case the function will not be able to reuse it, because
it requires a specific context to access the WGL framebuffer. It will
restore the original context afterwards to hide the context change from
load_location / preload callers. This is related to bug 34574.
@stefand
wined3d: Pass a context to surface_load_drawable and surface_blt_to_d…
c31740d 
…rawable.
@stefand
wined3d: Pass a context to surface_blt_fbo.
076ffec
@stefand
wined3d: Pass a context to surface_multisample_resolve.
3274381
@stefand
wined3d: Pass a context to surface_load_texture.
ab38b6f
@stefand
wined3d: Pass a context to surface_load_location.
3250f34
@stefand
wined3d: Make surface_load_location return nothing.
99aebeb
@stefand
wined3d: Store volume locations in the resource.
85995e4
@stefand
wined3d: Move validate_location to resource.c.
6faf995
@stefand
wined3d: Move surface locations into the resource.
b54e3ea
@stefand
wined3d: Remove surface_validate_location.
966751f
@stefand
wined3d: Move invalidate_location to resource.c.
0dbd6a8
@stefand
wined3d: Invalidate containers via callback.
9b559df
@stefand
wined3d: Remove surface_invalidate_location.
ead3547
@stefand
wined3d: Move bitmap_data and user_memory into the resource.
1e7ea96 
I may want to change this to keep this in the surface. Not sure yet.
@stefand
wined3d: Move load_location into the resource.
fa80b9d 
The resource part of load_location will handle transfers between sysmem
locations (heap memory, user memory, dib) and buffers. Texture loading
and downloading from textures will be delegated to surfaces / volumes.
@stefand
wined3d: Replace surface_load_location with resource_load_location.
073f901 
FIXME: Check if this patch is complete enough to make sense.
@stefand
wined3d: Introduce helper functions for mapping volumes.
9be9dd0
@stefand
wined3d: Move volume PBO infrastructure into the resource.
8ac5407
@stefand
wined3d: Remove surface->pbo.
898a6b2
@stefand
wined3d: Use resource buffer mapping facilities in surfaces.
4b5cf6d
@stefand
wined3d: Move buffer creation into the resource.
92c7870 
More code from volume_unload can be moved to resource_unload eventually.
Before doing that, surfaces and buffers have to be migrated to the new
location scheme. Otherwise the unimplemented buffer_load_location and
surface_load_location will write a lot of ERRs.
@stefand
wined3d: Handle WINED3D_LOCATION_DISCARDED in surface_load_texture.
ad670c7 
TODO: Move texture allocation to the caller, this way discarded locations can be handled in the resource.
@stefand
wined3d: Handle LOCATION_DISCARDED in surface_load_drawable.
1666fda
@stefand
wined3d: Handle WINED3D_LOCATION_DISCARDED for sysmem loads.
f3b3f74
@stefand
wined3d: Discard implicit surfaces on unload.
fb06a71
@stefand
wined3d: Don't try to flip sysmem copies in swapchain_present.
9316f4e 
This was once an optimization for ddraw applications that mapped the
backbuffer to render movies. It doesn't work any more in the intended
fashion.
@stefand
wined3d: Discard the backbuffer in discard presents.
fa2879d
kakra pushed a commit to kakra/wine that referenced this pull request Sep 6, 2018
@zfigura @kakra
ntdll: Fix a missing break statement.
1a29a11 
Should fix wine-mirror#2, wine-mirror#3, wine-mirror#6.
kakra pushed a commit to kakra/wine that referenced this pull request Sep 8, 2018
@zfigura @kakra
ntdll: Fix a missing break statement.
8d567ac 
Should fix wine-mirror#2, wine-mirror#3, wine-mirror#6.
kakra pushed a commit to kakra/wine that referenced this pull request Sep 8, 2018
@zfigura @kakra
ntdll: Fix a missing break statement.
b56629d 
Should fix wine-mirror#2, wine-mirror#3, wine-mirror#6.
kakra pushed a commit to kakra/wine that referenced this pull request Sep 8, 2018
@zfigura @kakra
ntdll: Fix a missing break statement.
2581c59 
Should fix wine-mirror#2, wine-mirror#3, wine-mirror#6.
kakra pushed a commit to kakra/wine that referenced this pull request Sep 8, 2018
@zfigura @kakra
ntdll: Fix a missing break statement.
05c2772 
Should fix wine-mirror#2, wine-mirror#3, wine-mirror#6.
kakra pushed a commit to kakra/wine that referenced this pull request Sep 8, 2018
@zfigura @kakra
ntdll: Fix a missing break statement.
48a7e42 
Should fix wine-mirror#2, wine-mirror#3, wine-mirror#6.
kakra added a commit to kakra/wine that referenced this pull request Sep 18, 2018
@kakra
dinput8: Fix building with SDL
efea594 
When SDL support was introduced to dinput, it fails linking of dinput8
in a later wine version probably due to pulling in dependecies from
dinput. This commit fixes it by adding the proper depends to
Makefile.in.

Fixes: Commit 045f32e ("dinput: Add SDL support")
Fixes: Commit 0f49071 ("dinput: Implement FF effects for SDL joysticks")
CC: Aric Stewart <[email protected]> wine-mirror#3.15
Signed-off-by: Kai Krakow <[email protected]>
kakra added a commit to kakra/wine that referenced this pull request Sep 18, 2018
@kakra
dinput8: Fix building with SDL
f034926 
When SDL support was introduced to dinput, it fails linking of dinput8
in a later wine version probably due to pulling in dependecies from
dinput. This commit fixes it by adding the proper depends to
Makefile.in.

Fixes: Commit 045f32e ("dinput: Add SDL support")
Fixes: Commit 0f49071 ("dinput: Implement FF effects for SDL joysticks")
CC: Aric Stewart <[email protected]> wine-mirror#3.15
Signed-off-by: Kai Krakow <[email protected]>
kakra pushed a commit to kakra/wine that referenced this pull request Sep 18, 2018
@zfigura @kakra
ntdll: Fix a missing break statement.
1f512a5 
Should fix wine-mirror#2, wine-mirror#3, wine-mirror#6.
kakra added a commit to kakra/wine that referenced this pull request Sep 23, 2018
@kakra
dinput8: Fix building with SDL
e72a677 
When SDL support was introduced to dinput, it fails linking of dinput8
in a later wine version probably due to pulling in dependecies from
dinput. This commit fixes it by adding the proper depends to
Makefile.in.

Fixes: Commit 045f32e ("dinput: Add SDL support")
Fixes: Commit 0f49071 ("dinput: Implement FF effects for SDL joysticks")
CC: Aric Stewart <[email protected]> wine-mirror#3.15
Signed-off-by: Kai Krakow <[email protected]>
kakra pushed a commit to kakra/wine that referenced this pull request Sep 23, 2018
@zfigura @kakra
ntdll: Fix a missing break statement.
e4d3d35 
Should fix wine-mirror#2, wine-mirror#3, wine-mirror#6.
kakra pushed a commit to kakra/wine that referenced this pull request Dec 14, 2018
@zfigura @kakra
ntdll: Fix a missing break statement.
f26b021 
Should fix wine-mirror#2, wine-mirror#3, wine-mirror#6.
kakra added a commit to kakra/wine that referenced this pull request Dec 14, 2018
@kakra
dinput8: Fix building with SDL
a27c41a 
When SDL support was introduced to dinput, it fails linking of dinput8
in a later wine version probably due to pulling in dependecies from
dinput. This commit fixes it by adding the proper depends to
Makefile.in.

Fixes: Commit 045f32e ("dinput: Add SDL support")
Fixes: Commit 0f49071 ("dinput: Implement FF effects for SDL joysticks")
CC: Aric Stewart <[email protected]> wine-mirror#3.15
Signed-off-by: Kai Krakow <[email protected]>
felixhaedicke pushed a commit to felixhaedicke/wine that referenced this pull request Jul 2, 2019
@zfigura @aeikum
ntdll: Fix a missing break statement.
f8e52b5 
Should fix wine-mirror#2, wine-mirror#3, wine-mirror#6.
neurotensin added a commit to neurotensin/wine-patched that referenced this pull request Jul 18, 2019
@neurotensin
changed assert (arg < sym->argc); to if assert (arg < sym->argc) retu…
d3bb899 
…rn NULL, to allow program to finish

have a DLL that only gets partially processed, and has the following stack:
winedump: symbol.c:184: symbol_get_spec_type: Assertion `0' failed.

Program received signal SIGABRT, Aborted.
0xf7fd4dc9 in __kernel_vsyscall ()
(gdb) where
#0  0xf7fd4dc9 in __kernel_vsyscall ()
wine-staging#1  0xf7ddf832 in raise () from /lib/i386-linux-gnu/libc.so.6
wine-staging#2  0xf7de0cc1 in abort () from /lib/i386-linux-gnu/libc.so.6
wine-mirror#3  0xf7dd77bb in ?? () from /lib/i386-linux-gnu/libc.so.6
wine-mirror#4  0xf7dd7819 in __assert_fail () from /lib/i386-linux-gnu/libc.so.6
wine-mirror#5  0x5656ff9a in symbol_get_spec_type (sym=0xffffd05c, arg=1) at symbol.c:184
wine-mirror#6  0x565661b5 in output_spec_symbol (sym=0xffffd05c) at output.c:107
wine-mirror#7  0x56556d25 in main ()
imaami pushed a commit to imaami/wine that referenced this pull request Jul 31, 2019
@zfigura @aeikum
ntdll: Fix a missing break statement.
ded6f0f 
Should fix wine-mirror#2, wine-mirror#3, wine-mirror#6.
imaami pushed a commit to imaami/wine that referenced this pull request Jul 31, 2019
@zfigura @aeikum
ntdll: Fix a missing break statement.
b302563 
Should fix wine-mirror#2, wine-mirror#3, wine-mirror#6.
imaami pushed a commit to imaami/wine that referenced this pull request Jul 31, 2019
@zfigura @imaami
ntdll: Fix a missing break statement.
0834978 
Should fix wine-mirror#2, wine-mirror#3, wine-mirror#6.
imaami pushed a commit to imaami/wine that referenced this pull request Aug 1, 2019
@zfigura @imaami
ntdll: Fix a missing break statement.
88c6f19 
Should fix wine-mirror#2, wine-mirror#3, wine-mirror#6.
imaami pushed a commit to imaami/wine that referenced this pull request Aug 3, 2019
@zfigura @imaami
ntdll: Fix a missing break statement.
200b8e4 
Should fix wine-mirror#2, wine-mirror#3, wine-mirror#6.
imaami pushed a commit to imaami/wine that referenced this pull request Aug 22, 2019
@zfigura @imaami
ntdll: Fix a missing break statement.
2f3cbba 
Should fix wine-mirror#2, wine-mirror#3, wine-mirror#6.
Guy1524 referenced this pull request in Guy1524/wine Dec 6, 2019
@zfigura @Guy1524
ntdll: Fix a missing break statement.
f7f03f1 
Should fix #2, #3, #6.
Guy1524 referenced this pull request in Guy1524/wine Jan 17, 2020
@zfigura @Guy1524
ntdll: Fix a missing break statement.
78a2ad8 
Should fix #2, #3, #6.
zzhiyi pushed a commit to zzhiyi/wine that referenced this pull request Jan 26, 2020
@zfigura @aeikum
ntdll: Fix a missing break statement.
cca00d4 
Should fix wine-mirror#2, wine-mirror#3, wine-mirror#6.
Guy1524 referenced this pull request in Guy1524/wine Jul 13, 2020
@zfigura @Guy1524
ntdll: Fix a missing break statement.
8165b06 
Should fix #2, #3, #6.
jeremyd2019 pushed a commit to jeremyd2019/wine that referenced this pull request Jun 11, 2024
@bernhardu @jeremyd2019
ws2_32: Disable check for local socket handles.
d1e5a96 
MSYS does a `dup(sockfd)` via DuplicateHandle.
Unfortunately that way the new handle is not contained in
the ws2_32.socket_list.

This change just disables this check to workaround this.


Kind of related: https://bugs.winehq.org/show_bug.cgi?id=54413


wine c:/msys64/usr/bin/git.exe clone --mirror git://sourceware.org/git/newlib-cygwin.git /home/bernhard/MSYS2-packages/msys2-runtime/msys2-runtime


(rr) list fhandler_base::dup
1320    int
1321    fhandler_base::dup (fhandler_base *child, int flags)
1322    {
1323      debug_printf ("in fhandler_base dup");
1324
1325      HANDLE nh;
1326      if (!nohandle () && !archetype)
1327        {
1328          if (!DuplicateHandle (GetCurrentProcess (), get_handle (),
1329                                GetCurrentProcess (), &nh,
1330                                0, !(flags & O_CLOEXEC), DUPLICATE_SAME_ACCESS))
1331            {
1332              debug_printf ("dup(%s) failed, handle %p, %E",
1333                            get_name (), get_handle ());
1334              __seterrno ();
1335              return -1;
1336            }
1337
1338          VerifyHandle (nh);
1339          child->set_handle (nh);
1340        }
1341      return 0;
1342    }
(rr) print x
$29 = (HANDLE) 0x150
(rr) bt
#0  fhandler_base::set_handle (this=0x800027a28, x=0x150) at /home/Benutzer1/MSYS2-packages/msys2-runtime/src/msys2-runtime/winsup/cygwin/local_includes/fhandler.h:238
wine-mirror#1  0x000000018011315a in fhandler_base::dup (this=0x800027318, child=0x800027a28, flags=32768) at /home/Benutzer1/MSYS2-packages/msys2-runtime/src/msys2-runtime/winsup/cygwin/fhandler/base.cc:1339
wine-mirror#2  0x000000018015a8c8 in fhandler_socket_wsock::dup (this=0x800027318, child=0x800027a28, flags=32768) at /home/Benutzer1/MSYS2-packages/msys2-runtime/src/msys2-runtime/winsup/cygwin/fhandler/socket_inet.cc:558
wine-mirror#3  0x000000018005f6ec in dtable::dup_worker (this=0x800004858, oldfh=0x800027318, flags=32768) at /home/Benutzer1/MSYS2-packages/msys2-runtime/src/msys2-runtime/winsup/cygwin/dtable.cc:707
wine-mirror#4  0x000000018005fa56 in dtable::dup3 (this=0x800004858, oldfd=3, newfd=4, flags=32768) at /home/Benutzer1/MSYS2-packages/msys2-runtime/src/msys2-runtime/winsup/cygwin/dtable.cc:774
wine-mirror#5  0x00000001800dd567 in dup (fd=3) at /home/Benutzer1/MSYS2-packages/msys2-runtime/src/msys2-runtime/winsup/cygwin/syscalls.cc:96
wine-mirror#6  0x00000001801c348b in _sigfe () at sigfe.s:36
wine-mirror#7  0x0000000a00000003 in ?? ()
wine-mirror#8  0x0000000000000040 in ?? ()
wine-mirror#9  0x0a0a0a0a0a0a0a0a in ?? ()
wine-mirror#10 0x0000000a00003e66 in ?? ()
wine-mirror#11 0x0000000a00003e90 in ?? ()
wine-mirror#12 0x000000010050d4b2 in git_connect_git (fd=fd@entry=0xa00003c40, hostandport=0xa00003e70 "sourceware.org", path=0xa00003e50 "/git/newlib-cygwin.git", prog=prog@entry=0x10067bcd9 <junk_leave_repo_msg+1913> "git-upload-pack", version=version@entry=protocol_v2, flags=flags@entry=0) at connect.c:1257
wine-mirror#13 0x000000010050e4ad in git_connect (fd=fd@entry=0xa00003c40, url=0xa000033e0 "git://sourceware.org/git/newlib-cygwin.git", prog=0x10067bcd9 <junk_leave_repo_msg+1913> "git-upload-pack", flags=0) at connect.c:1437
wine-mirror#14 0x0000000100622f65 in connect_setup (transport=transport@entry=0xa000038a0, for_push=for_push@entry=0) at transport.c:278
wine-mirror#15 0x0000000100623043 in handshake (transport=0xa000038a0, for_push=0, options=0x67dfc800, must_list_refs=must_list_refs@entry=1) at transport.c:313
wine-mirror#16 0x0000000100623254 in get_refs_via_connect (transport=<optimized out>, for_push=<optimized out>, options=<optimized out>) at transport.c:360
wine-mirror#17 0x0000000100624f9c in transport_get_remote_refs (transport=transport@entry=0xa000038a0, transport_options=transport_options@entry=0x67dfc800) at transport.c:1474
wine-mirror#18 0x0000000100426005 in cmd_clone (argc=<optimized out>, argv=<optimized out>, prefix=<optimized out>) at builtin/clone.c:1274
wine-mirror#19 0x0000000100401330 in run_builtin (p=0x10065a218 <commands+504>, argc=argc@entry=4, argv=argv@entry=0x67dfcc08) at git.c:445
wine-mirror#20 0x00000001004015e2 in handle_builtin (argc=4, argv=0x67dfcc08) at git.c:699
wine-mirror#21 0x0000000100402aa3 in run_argv (argcp=argcp@entry=0x67dfcb70, argv=argv@entry=0x67dfcb78) at git.c:763
wine-mirror#22 0x0000000100402f28 in cmd_main (argc=<optimized out>, argc@entry=5, argv=<optimized out>, argv@entry=0x67dfcc00) at git.c:898
wine-mirror#23 0x00000001004ce4d7 in main (argc=5, argv=0x67dfcc00) at common-main.c:57
jeremyd2019 pushed a commit to jeremyd2019/wine that referenced this pull request Jun 12, 2024
@bernhardu @jhol
ws2_32: Disable check for local socket handles.
f9dce25 
MSYS does a `dup(sockfd)` via DuplicateHandle.
Unfortunately that way the new handle is not contained in
the ws2_32.socket_list.

This change just disables this check to workaround this.


Kind of related: https://bugs.winehq.org/show_bug.cgi?id=54413


wine c:/msys64/usr/bin/git.exe clone --mirror git://sourceware.org/git/newlib-cygwin.git /home/bernhard/MSYS2-packages/msys2-runtime/msys2-runtime


(rr) list fhandler_base::dup
1320    int
1321    fhandler_base::dup (fhandler_base *child, int flags)
1322    {
1323      debug_printf ("in fhandler_base dup");
1324
1325      HANDLE nh;
1326      if (!nohandle () && !archetype)
1327        {
1328          if (!DuplicateHandle (GetCurrentProcess (), get_handle (),
1329                                GetCurrentProcess (), &nh,
1330                                0, !(flags & O_CLOEXEC), DUPLICATE_SAME_ACCESS))
1331            {
1332              debug_printf ("dup(%s) failed, handle %p, %E",
1333                            get_name (), get_handle ());
1334              __seterrno ();
1335              return -1;
1336            }
1337
1338          VerifyHandle (nh);
1339          child->set_handle (nh);
1340        }
1341      return 0;
1342    }
(rr) print x
$29 = (HANDLE) 0x150
(rr) bt
#0  fhandler_base::set_handle (this=0x800027a28, x=0x150) at /home/Benutzer1/MSYS2-packages/msys2-runtime/src/msys2-runtime/winsup/cygwin/local_includes/fhandler.h:238
wine-mirror#1  0x000000018011315a in fhandler_base::dup (this=0x800027318, child=0x800027a28, flags=32768) at /home/Benutzer1/MSYS2-packages/msys2-runtime/src/msys2-runtime/winsup/cygwin/fhandler/base.cc:1339
wine-mirror#2  0x000000018015a8c8 in fhandler_socket_wsock::dup (this=0x800027318, child=0x800027a28, flags=32768) at /home/Benutzer1/MSYS2-packages/msys2-runtime/src/msys2-runtime/winsup/cygwin/fhandler/socket_inet.cc:558
wine-mirror#3  0x000000018005f6ec in dtable::dup_worker (this=0x800004858, oldfh=0x800027318, flags=32768) at /home/Benutzer1/MSYS2-packages/msys2-runtime/src/msys2-runtime/winsup/cygwin/dtable.cc:707
wine-mirror#4  0x000000018005fa56 in dtable::dup3 (this=0x800004858, oldfd=3, newfd=4, flags=32768) at /home/Benutzer1/MSYS2-packages/msys2-runtime/src/msys2-runtime/winsup/cygwin/dtable.cc:774
wine-mirror#5  0x00000001800dd567 in dup (fd=3) at /home/Benutzer1/MSYS2-packages/msys2-runtime/src/msys2-runtime/winsup/cygwin/syscalls.cc:96
wine-mirror#6  0x00000001801c348b in _sigfe () at sigfe.s:36
wine-mirror#7  0x0000000a00000003 in ?? ()
wine-mirror#8  0x0000000000000040 in ?? ()
wine-mirror#9  0x0a0a0a0a0a0a0a0a in ?? ()
wine-mirror#10 0x0000000a00003e66 in ?? ()
wine-mirror#11 0x0000000a00003e90 in ?? ()
wine-mirror#12 0x000000010050d4b2 in git_connect_git (fd=fd@entry=0xa00003c40, hostandport=0xa00003e70 "sourceware.org", path=0xa00003e50 "/git/newlib-cygwin.git", prog=prog@entry=0x10067bcd9 <junk_leave_repo_msg+1913> "git-upload-pack", version=version@entry=protocol_v2, flags=flags@entry=0) at connect.c:1257
wine-mirror#13 0x000000010050e4ad in git_connect (fd=fd@entry=0xa00003c40, url=0xa000033e0 "git://sourceware.org/git/newlib-cygwin.git", prog=0x10067bcd9 <junk_leave_repo_msg+1913> "git-upload-pack", flags=0) at connect.c:1437
wine-mirror#14 0x0000000100622f65 in connect_setup (transport=transport@entry=0xa000038a0, for_push=for_push@entry=0) at transport.c:278
wine-mirror#15 0x0000000100623043 in handshake (transport=0xa000038a0, for_push=0, options=0x67dfc800, must_list_refs=must_list_refs@entry=1) at transport.c:313
wine-mirror#16 0x0000000100623254 in get_refs_via_connect (transport=<optimized out>, for_push=<optimized out>, options=<optimized out>) at transport.c:360
wine-mirror#17 0x0000000100624f9c in transport_get_remote_refs (transport=transport@entry=0xa000038a0, transport_options=transport_options@entry=0x67dfc800) at transport.c:1474
wine-mirror#18 0x0000000100426005 in cmd_clone (argc=<optimized out>, argv=<optimized out>, prefix=<optimized out>) at builtin/clone.c:1274
wine-mirror#19 0x0000000100401330 in run_builtin (p=0x10065a218 <commands+504>, argc=argc@entry=4, argv=argv@entry=0x67dfcc08) at git.c:445
wine-mirror#20 0x00000001004015e2 in handle_builtin (argc=4, argv=0x67dfcc08) at git.c:699
wine-mirror#21 0x0000000100402aa3 in run_argv (argcp=argcp@entry=0x67dfcb70, argv=argv@entry=0x67dfcb78) at git.c:763
wine-mirror#22 0x0000000100402f28 in cmd_main (argc=<optimized out>, argc@entry=5, argv=<optimized out>, argv@entry=0x67dfcc00) at git.c:898
wine-mirror#23 0x00000001004ce4d7 in main (argc=5, argv=0x67dfcc00) at common-main.c:57
jeremyd2019 pushed a commit to jeremyd2019/wine that referenced this pull request Jun 15, 2024
@bernhardu @jeremyd2019
ws2_32: Disable check for local socket handles.
8c7be8a 
MSYS does a `dup(sockfd)` via DuplicateHandle.
Unfortunately that way the new handle is not contained in
the ws2_32.socket_list.

This change just disables this check to workaround this.


Kind of related: https://bugs.winehq.org/show_bug.cgi?id=54413


wine c:/msys64/usr/bin/git.exe clone --mirror git://sourceware.org/git/newlib-cygwin.git /home/bernhard/MSYS2-packages/msys2-runtime/msys2-runtime


(rr) list fhandler_base::dup
1320    int
1321    fhandler_base::dup (fhandler_base *child, int flags)
1322    {
1323      debug_printf ("in fhandler_base dup");
1324
1325      HANDLE nh;
1326      if (!nohandle () && !archetype)
1327        {
1328          if (!DuplicateHandle (GetCurrentProcess (), get_handle (),
1329                                GetCurrentProcess (), &nh,
1330                                0, !(flags & O_CLOEXEC), DUPLICATE_SAME_ACCESS))
1331            {
1332              debug_printf ("dup(%s) failed, handle %p, %E",
1333                            get_name (), get_handle ());
1334              __seterrno ();
1335              return -1;
1336            }
1337
1338          VerifyHandle (nh);
1339          child->set_handle (nh);
1340        }
1341      return 0;
1342    }
(rr) print x
$29 = (HANDLE) 0x150
(rr) bt
#0  fhandler_base::set_handle (this=0x800027a28, x=0x150) at /home/Benutzer1/MSYS2-packages/msys2-runtime/src/msys2-runtime/winsup/cygwin/local_includes/fhandler.h:238
wine-mirror#1  0x000000018011315a in fhandler_base::dup (this=0x800027318, child=0x800027a28, flags=32768) at /home/Benutzer1/MSYS2-packages/msys2-runtime/src/msys2-runtime/winsup/cygwin/fhandler/base.cc:1339
wine-mirror#2  0x000000018015a8c8 in fhandler_socket_wsock::dup (this=0x800027318, child=0x800027a28, flags=32768) at /home/Benutzer1/MSYS2-packages/msys2-runtime/src/msys2-runtime/winsup/cygwin/fhandler/socket_inet.cc:558
wine-mirror#3  0x000000018005f6ec in dtable::dup_worker (this=0x800004858, oldfh=0x800027318, flags=32768) at /home/Benutzer1/MSYS2-packages/msys2-runtime/src/msys2-runtime/winsup/cygwin/dtable.cc:707
wine-mirror#4  0x000000018005fa56 in dtable::dup3 (this=0x800004858, oldfd=3, newfd=4, flags=32768) at /home/Benutzer1/MSYS2-packages/msys2-runtime/src/msys2-runtime/winsup/cygwin/dtable.cc:774
wine-mirror#5  0x00000001800dd567 in dup (fd=3) at /home/Benutzer1/MSYS2-packages/msys2-runtime/src/msys2-runtime/winsup/cygwin/syscalls.cc:96
wine-mirror#6  0x00000001801c348b in _sigfe () at sigfe.s:36
wine-mirror#7  0x0000000a00000003 in ?? ()
wine-mirror#8  0x0000000000000040 in ?? ()
wine-mirror#9  0x0a0a0a0a0a0a0a0a in ?? ()
wine-mirror#10 0x0000000a00003e66 in ?? ()
wine-mirror#11 0x0000000a00003e90 in ?? ()
wine-mirror#12 0x000000010050d4b2 in git_connect_git (fd=fd@entry=0xa00003c40, hostandport=0xa00003e70 "sourceware.org", path=0xa00003e50 "/git/newlib-cygwin.git", prog=prog@entry=0x10067bcd9 <junk_leave_repo_msg+1913> "git-upload-pack", version=version@entry=protocol_v2, flags=flags@entry=0) at connect.c:1257
wine-mirror#13 0x000000010050e4ad in git_connect (fd=fd@entry=0xa00003c40, url=0xa000033e0 "git://sourceware.org/git/newlib-cygwin.git", prog=0x10067bcd9 <junk_leave_repo_msg+1913> "git-upload-pack", flags=0) at connect.c:1437
wine-mirror#14 0x0000000100622f65 in connect_setup (transport=transport@entry=0xa000038a0, for_push=for_push@entry=0) at transport.c:278
wine-mirror#15 0x0000000100623043 in handshake (transport=0xa000038a0, for_push=0, options=0x67dfc800, must_list_refs=must_list_refs@entry=1) at transport.c:313
wine-mirror#16 0x0000000100623254 in get_refs_via_connect (transport=<optimized out>, for_push=<optimized out>, options=<optimized out>) at transport.c:360
wine-mirror#17 0x0000000100624f9c in transport_get_remote_refs (transport=transport@entry=0xa000038a0, transport_options=transport_options@entry=0x67dfc800) at transport.c:1474
wine-mirror#18 0x0000000100426005 in cmd_clone (argc=<optimized out>, argv=<optimized out>, prefix=<optimized out>) at builtin/clone.c:1274
wine-mirror#19 0x0000000100401330 in run_builtin (p=0x10065a218 <commands+504>, argc=argc@entry=4, argv=argv@entry=0x67dfcc08) at git.c:445
wine-mirror#20 0x00000001004015e2 in handle_builtin (argc=4, argv=0x67dfcc08) at git.c:699
wine-mirror#21 0x0000000100402aa3 in run_argv (argcp=argcp@entry=0x67dfcb70, argv=argv@entry=0x67dfcb78) at git.c:763
wine-mirror#22 0x0000000100402f28 in cmd_main (argc=<optimized out>, argc@entry=5, argv=<optimized out>, argv@entry=0x67dfcc00) at git.c:898
wine-mirror#23 0x00000001004ce4d7 in main (argc=5, argv=0x67dfcc00) at common-main.c:57
jeremyd2019 pushed a commit to jeremyd2019/wine that referenced this pull request Jun 17, 2024
@bernhardu @jeremyd2019
ws2_32: Disable check for local socket handles.
d09dc5c 
MSYS does a `dup(sockfd)` via DuplicateHandle.
Unfortunately that way the new handle is not contained in
the ws2_32.socket_list.

This change just disables this check to workaround this.


Kind of related: https://bugs.winehq.org/show_bug.cgi?id=54413


wine c:/msys64/usr/bin/git.exe clone --mirror git://sourceware.org/git/newlib-cygwin.git /home/bernhard/MSYS2-packages/msys2-runtime/msys2-runtime


(rr) list fhandler_base::dup
1320    int
1321    fhandler_base::dup (fhandler_base *child, int flags)
1322    {
1323      debug_printf ("in fhandler_base dup");
1324
1325      HANDLE nh;
1326      if (!nohandle () && !archetype)
1327        {
1328          if (!DuplicateHandle (GetCurrentProcess (), get_handle (),
1329                                GetCurrentProcess (), &nh,
1330                                0, !(flags & O_CLOEXEC), DUPLICATE_SAME_ACCESS))
1331            {
1332              debug_printf ("dup(%s) failed, handle %p, %E",
1333                            get_name (), get_handle ());
1334              __seterrno ();
1335              return -1;
1336            }
1337
1338          VerifyHandle (nh);
1339          child->set_handle (nh);
1340        }
1341      return 0;
1342    }
(rr) print x
$29 = (HANDLE) 0x150
(rr) bt
#0  fhandler_base::set_handle (this=0x800027a28, x=0x150) at /home/Benutzer1/MSYS2-packages/msys2-runtime/src/msys2-runtime/winsup/cygwin/local_includes/fhandler.h:238
wine-mirror#1  0x000000018011315a in fhandler_base::dup (this=0x800027318, child=0x800027a28, flags=32768) at /home/Benutzer1/MSYS2-packages/msys2-runtime/src/msys2-runtime/winsup/cygwin/fhandler/base.cc:1339
wine-mirror#2  0x000000018015a8c8 in fhandler_socket_wsock::dup (this=0x800027318, child=0x800027a28, flags=32768) at /home/Benutzer1/MSYS2-packages/msys2-runtime/src/msys2-runtime/winsup/cygwin/fhandler/socket_inet.cc:558
wine-mirror#3  0x000000018005f6ec in dtable::dup_worker (this=0x800004858, oldfh=0x800027318, flags=32768) at /home/Benutzer1/MSYS2-packages/msys2-runtime/src/msys2-runtime/winsup/cygwin/dtable.cc:707
wine-mirror#4  0x000000018005fa56 in dtable::dup3 (this=0x800004858, oldfd=3, newfd=4, flags=32768) at /home/Benutzer1/MSYS2-packages/msys2-runtime/src/msys2-runtime/winsup/cygwin/dtable.cc:774
wine-mirror#5  0x00000001800dd567 in dup (fd=3) at /home/Benutzer1/MSYS2-packages/msys2-runtime/src/msys2-runtime/winsup/cygwin/syscalls.cc:96
wine-mirror#6  0x00000001801c348b in _sigfe () at sigfe.s:36
wine-mirror#7  0x0000000a00000003 in ?? ()
wine-mirror#8  0x0000000000000040 in ?? ()
wine-mirror#9  0x0a0a0a0a0a0a0a0a in ?? ()
wine-mirror#10 0x0000000a00003e66 in ?? ()
wine-mirror#11 0x0000000a00003e90 in ?? ()
wine-mirror#12 0x000000010050d4b2 in git_connect_git (fd=fd@entry=0xa00003c40, hostandport=0xa00003e70 "sourceware.org", path=0xa00003e50 "/git/newlib-cygwin.git", prog=prog@entry=0x10067bcd9 <junk_leave_repo_msg+1913> "git-upload-pack", version=version@entry=protocol_v2, flags=flags@entry=0) at connect.c:1257
wine-mirror#13 0x000000010050e4ad in git_connect (fd=fd@entry=0xa00003c40, url=0xa000033e0 "git://sourceware.org/git/newlib-cygwin.git", prog=0x10067bcd9 <junk_leave_repo_msg+1913> "git-upload-pack", flags=0) at connect.c:1437
wine-mirror#14 0x0000000100622f65 in connect_setup (transport=transport@entry=0xa000038a0, for_push=for_push@entry=0) at transport.c:278
wine-mirror#15 0x0000000100623043 in handshake (transport=0xa000038a0, for_push=0, options=0x67dfc800, must_list_refs=must_list_refs@entry=1) at transport.c:313
wine-mirror#16 0x0000000100623254 in get_refs_via_connect (transport=<optimized out>, for_push=<optimized out>, options=<optimized out>) at transport.c:360
wine-mirror#17 0x0000000100624f9c in transport_get_remote_refs (transport=transport@entry=0xa000038a0, transport_options=transport_options@entry=0x67dfc800) at transport.c:1474
wine-mirror#18 0x0000000100426005 in cmd_clone (argc=<optimized out>, argv=<optimized out>, prefix=<optimized out>) at builtin/clone.c:1274
wine-mirror#19 0x0000000100401330 in run_builtin (p=0x10065a218 <commands+504>, argc=argc@entry=4, argv=argv@entry=0x67dfcc08) at git.c:445
wine-mirror#20 0x00000001004015e2 in handle_builtin (argc=4, argv=0x67dfcc08) at git.c:699
wine-mirror#21 0x0000000100402aa3 in run_argv (argcp=argcp@entry=0x67dfcb70, argv=argv@entry=0x67dfcb78) at git.c:763
wine-mirror#22 0x0000000100402f28 in cmd_main (argc=<optimized out>, argc@entry=5, argv=<optimized out>, argv@entry=0x67dfcc00) at git.c:898
wine-mirror#23 0x00000001004ce4d7 in main (argc=5, argv=0x67dfcc00) at common-main.c:57
@Neustradamus
Copy link

Dear @wine-mirror team,

I would like to know who manage this organization and this repository.

Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrdeathjr28 @Neustradamus @stefand