-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch re-run jobs UI #4811
base: main
Are you sure you want to change the base?
Batch re-run jobs UI #4811
Conversation
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to e6d34df in 2 minutes and 21 seconds
More details
- Looked at
646
lines of code in5
files - Skipped
0
files when reviewing. - Skipped posting
4
drafted comments based on config settings.
1. frontend/src/lib/components/runs/BatchRerunPanel.svelte:39
- Draft comment:
Avoid using non-null assertion operator (!) with $workspaceStore. Consider handling the case where $workspaceStore might be null or undefined to prevent potential runtime errors. - Reason this comment was not posted:
Marked as duplicate.
2. frontend/src/lib/components/runs/BatchRerunPanel.svelte:47
- Draft comment:
Avoid using non-null assertion operator (!) with $workspaceStore. Consider handling the case where $workspaceStore might be null or undefined to prevent potential runtime errors. - Reason this comment was not posted:
Marked as duplicate.
3. frontend/src/lib/components/runs/BatchRerunPanel.svelte:54
- Draft comment:
Avoid using non-null assertion operator (!) with $workspaceStore. Consider handling the case where $workspaceStore might be null or undefined to prevent potential runtime errors. - Reason this comment was not posted:
Marked as duplicate.
4. frontend/src/routes/(root)/(logged)/runs/[...path]/+page.svelte:703
- Draft comment:
Avoid using non-null assertion operator (!) with $workspaceStore. Consider handling the case where $workspaceStore might be null or undefined to prevent potential runtime errors. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_Zry2FjQxwl0YaxZn
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
if (job.script_hash) { | ||
schemas[job.id] = ( | ||
await ScriptService.getScriptByHash({ | ||
workspace: $workspaceStore!, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid using non-null assertion operator (!) with $workspaceStore. Consider handling the case where $workspaceStore might be null or undefined to prevent potential runtime errors.
f85cf46
to
2c5d07f
Compare
This is the first version of the Jobs UI Batch Re-run feature, addressing #4787
This PR implements
<BatchRerunPanel />
to allow to the user to override old arguments for each selected job (each job is a tab)<SchemaForm />
componentImportant
Add batch re-run feature for jobs in the UI, allowing selection and argument override for completed jobs.
BatchRerunPanel.svelte
to handle UI for batch re-running jobs, allowing argument overrides.RunRow.svelte
andRunsTable.svelte
to support job selection for re-running.isJobRerunnable()
inutils.ts
to determine if a job can be re-run.+page.svelte
, including fetching job arguments and executing re-runs.This description was created by for e6d34df. It will automatically update as commits are pushed.