Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch re-run jobs UI #4811

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ricin9
Copy link

@ricin9 ricin9 commented Nov 28, 2024

This is the first version of the Jobs UI Batch Re-run feature, addressing #4787

This PR implements

  • A Batch re-run jobs button in the Runs page which when clicked allows you to select jobs that are re-runnable (job is completed and is either a script or a flow), similar to the Cancel job feature
  • When selecting jobs to be re-ran, the bottom right panel is used by a new component <BatchRerunPanel /> to allow to the user to override old arguments for each selected job (each job is a tab)
    • When visiting a tab, the UI fetches both the job's input schema and its arguments to display the <SchemaForm /> component
    • When starting the re-run the UI fetches all the jobs arguments which were not overridden in the panel, then runs all the scripts by hash or flows by path

Important

Add batch re-run feature for jobs in the UI, allowing selection and argument override for completed jobs.

  • UI Components:
    • Add BatchRerunPanel.svelte to handle UI for batch re-running jobs, allowing argument overrides.
    • Update RunRow.svelte and RunsTable.svelte to support job selection for re-running.
  • Utilities:
    • Add isJobRerunnable() in utils.ts to determine if a job can be re-run.
  • Functionality:
    • Implement batch re-run logic in +page.svelte, including fetching job arguments and executing re-runs.
    • Add UI elements for selecting and confirming batch re-runs, similar to the cancel feature.

This description was created by Ellipsis for e6d34df. It will automatically update as commits are pushed.

@ricin9 ricin9 requested a review from rubenfiszel as a code owner November 28, 2024 10:56
Copy link
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to e6d34df in 2 minutes and 21 seconds

More details
  • Looked at 646 lines of code in 5 files
  • Skipped 0 files when reviewing.
  • Skipped posting 4 drafted comments based on config settings.
1. frontend/src/lib/components/runs/BatchRerunPanel.svelte:39
  • Draft comment:
    Avoid using non-null assertion operator (!) with $workspaceStore. Consider handling the case where $workspaceStore might be null or undefined to prevent potential runtime errors.
  • Reason this comment was not posted:
    Marked as duplicate.
2. frontend/src/lib/components/runs/BatchRerunPanel.svelte:47
  • Draft comment:
    Avoid using non-null assertion operator (!) with $workspaceStore. Consider handling the case where $workspaceStore might be null or undefined to prevent potential runtime errors.
  • Reason this comment was not posted:
    Marked as duplicate.
3. frontend/src/lib/components/runs/BatchRerunPanel.svelte:54
  • Draft comment:
    Avoid using non-null assertion operator (!) with $workspaceStore. Consider handling the case where $workspaceStore might be null or undefined to prevent potential runtime errors.
  • Reason this comment was not posted:
    Marked as duplicate.
4. frontend/src/routes/(root)/(logged)/runs/[...path]/+page.svelte:703
  • Draft comment:
    Avoid using non-null assertion operator (!) with $workspaceStore. Consider handling the case where $workspaceStore might be null or undefined to prevent potential runtime errors.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_Zry2FjQxwl0YaxZn


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

if (job.script_hash) {
schemas[job.id] = (
await ScriptService.getScriptByHash({
workspace: $workspaceStore!,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid using non-null assertion operator (!) with $workspaceStore. Consider handling the case where $workspaceStore might be null or undefined to prevent potential runtime errors.

@rubenfiszel rubenfiszel force-pushed the main branch 6 times, most recently from f85cf46 to 2c5d07f Compare December 9, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant