External ssl termination #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First of all thanks for contributing! I am not sure if the user will understand what terminate ssl means. I wonder if we should simply call the option useSsl and only if that is enabled the certificate will be taken .... |
|
thanks alot |
|
|
|
I merged yours as it points out that it disables ssl for reverse proxy which is also clearly understandable. Thanks alot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've gone ahead and added a
sslterminatedoption along with its UI. This allow the Telegram bot node to start a bare HTTP server, without the need to handle SSL-related stuff. It is suitable for some localtunnel-style architecture like this:This way the SSL termination happens only on the cloud server, and could be easily integrated with Let's Encrypt.
This fixes #92 .