add: action name

windingwind · Sep 15, 2023 · 0f57d9e · 0f57d9e
1 parent b870c45
commit 0f57d9e
Show file tree

Hide file tree

Showing 4 changed files with 37 additions and 8 deletions.
diff --git a/addon/locale/en-US/addon.ftl b/addon/locale/en-US/addon.ftl
@@ -1,5 +1,6 @@
 prefs-title = Actions & Tags
 
+prefs-rule-name = Name
 prefs-rule-event = Event
 prefs-rule-operation = Operation
 prefs-rule-data = Data

diff --git a/addon/locale/zh-CN/addon.ftl b/addon/locale/zh-CN/addon.ftl
@@ -1,5 +1,6 @@
 prefs-title = Actions & Tags
 
+prefs-rule-name = 名称
 prefs-rule-event = 事件
 prefs-rule-operation = 操作
 prefs-rule-data = 数据

diff --git a/src/modules/preferenceWindow.ts b/src/modules/preferenceWindow.ts
@@ -31,12 +31,16 @@ async function initUI() {
   if (!isWindowAlive(addon.data.prefs.window)) return;
   updateCachedActionKeys();
   addon.data.prefs.tableHelper = new ztoolkit.VirtualizedTable(
-    addon.data.prefs.window!,
+    addon.data.prefs.window!
   )
     .setContainerId(`${config.addonRef}-table-container`)
     .setProp({
       id: `${config.addonRef}-prefs-table`,
       columns: [
+        {
+          dataKey: "name",
+          label: getString("prefs-rule-name"),
+        },
         {
           dataKey: "event",
           label: getString("prefs-rule-event"),
@@ -165,12 +169,13 @@ function getRowData(index: number) {
   return {
     event: getString(`prefs-rule-event-${ActionEventTypes[action.event]}`),
     operation: getString(
-      `prefs-rule-operation-${ActionOperationTypes[action.operation]}`,
+      `prefs-rule-operation-${ActionOperationTypes[action.operation]}`
     ),
     data: action.data,
     shortcut: action.shortcut,
     enabled: action.enabled,
     menu: action.menu || "❌",
+    name: action.name || "",
   };
 }
 
@@ -198,6 +203,23 @@ async function editAction(currentKey?: string) {
         columnGap: "5px",
       },
       children: [
+        {
+          tag: "label",
+          namespace: "html",
+          properties: {
+            textContent: getString("prefs-rule-name"),
+          },
+        },
+        {
+          tag: "input",
+          attributes: {
+            "data-bind": "name",
+            "data-prop": "value",
+          },
+          styles: {
+            width: "fit-content",
+          },
+        },
         {
           tag: "label",
           namespace: "html",
@@ -286,7 +308,7 @@ async function editAction(currentKey?: string) {
                     const content = await openEditorWindow(dialogData.data);
                     (
                       dialog.window.document.querySelector(
-                        "#data-input",
+                        "#data-input"
                       ) as HTMLTextAreaElement
                     ).value = content;
                     dialogData.data = content;
@@ -320,7 +342,7 @@ async function editAction(currentKey?: string) {
                 const key = ev.target as HTMLElement;
                 const win = dialog.window;
                 key.textContent = `[${getString(
-                  "prefs-rule-edit-shortcut-placeholder",
+                  "prefs-rule-edit-shortcut-placeholder"
                 )}]`;
                 dialogData.shortcut = "";
                 const keyDownListener = (e: KeyboardEvent) => {
@@ -414,6 +436,7 @@ async function editAction(currentKey?: string) {
           shortcut: dialogData.shortcut.replace(/\[(.*?)\]/g, ""),
           enabled: dialogData.enabled,
           menu: dialogData.menu,
+          name: dialogData.name,
         });
         updateUI();
       }
@@ -430,7 +453,7 @@ async function openEditorWindow(content: string) {
   const editorWin = addon.data.prefs.window?.openDialog(
     "chrome://scaffold/content/monaco/monaco.html",
     "monaco",
-    "chrome,centerscreen,dialog=no,resizable,scrollbars=yes,width=800,height=600",
+    "chrome,centerscreen,dialog=no,resizable,scrollbars=yes,width=800,height=600"
   ) as
     | (Window & {
         loadMonaco: (options: Record<string, any>) => Promise<{ editor: any }>;

diff --git a/src/utils/actions.ts b/src/utils/actions.ts
@@ -46,12 +46,14 @@ interface ActionData<T extends ActionOperationTypes = ActionOperationTypes> {
   shortcut?: string;
   enabled?: boolean;
   menu?: string;
+  name?: string;
 }
 
 const defaultActions: ActionMap = new Map([
   [
     "default0",
     {
+      name: "Add Unread When Create Item",
       event: ActionEventTypes.createItem,
       operation: ActionOperationTypes.add,
       data: "/unread",
@@ -62,6 +64,7 @@ const defaultActions: ActionMap = new Map([
   [
     "default1",
     {
+      name: "Remove Unread When Close Tab",
       event: ActionEventTypes.closeTab,
       operation: ActionOperationTypes.remove,
       data: "/unread",
@@ -78,6 +81,7 @@ const emptyAction: ActionData = {
   shortcut: "",
   enabled: true,
   menu: "",
+  name: "",
 };
 
 type ActionMap = Map<string, ActionData>;
@@ -91,7 +95,7 @@ function initActions() {
   addon.data.actions.map = new ztoolkit.LargePref(
     `${config.prefsPrefix}.rules`,
     `${config.prefsPrefix}.rules.`,
-    "parser",
+    "parser"
   ).asMapLike() as ActionMap;
   if (!getPref("rulesInit")) {
     for (const key of defaultActions.keys()) {
@@ -132,7 +136,7 @@ async function applyAction(rule: ActionData, data: ActionDataData) {
         item?.removeTag(tag);
       }
       message = `Remove tag ${tags.join(",")} from item ${item?.getField(
-        "title",
+        "title"
       )}`;
       break;
     }
@@ -145,7 +149,7 @@ async function applyAction(rule: ActionData, data: ActionDataData) {
         }
       }
       message = `Toggle tag ${tags.join(",")} to item ${item?.getField(
-        "title",
+        "title"
       )}`;
       break;
     }