Skip to content

Commit

Permalink
Handle existing wheels when building Python library
Browse files Browse the repository at this point in the history
  • Loading branch information
wilsonzlin committed Jun 17, 2022
1 parent 337de1f commit fd60983
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 2 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/python.yml
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,8 @@ jobs:
# On macOS ARM64 this may emit a warning like "Couldn't find the symbol `PyInit_minify_html_core` in the native library. Python will fail to import this module." Ignore this message.
maturin build --release --strip -i "$pathToPython"
if [[ "$GITHUB_REF" == refs/tags/v* ]]; then
twine upload target/wheels/*
# For idempotency, ignore any existing built wheels that have already been successfully uploaded.
twine upload --skip-existing target/wheels/*
else
ls -al target/wheels/*
fi
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# minify-html changelog

## 0.8.2

- Fix Python build pipeline to handle existing uploaded wheels from previous successful build attempts.

## 0.8.1

- Create wrapper index.js for Node.js library to support ESM.
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ A Rust HTML minifier meticulously optimised for speed and effectiveness, with bi

## Performance

Comparison with [html-minfier](https://github.com/kangax/html-minifier) and [minimize](https://github.com/Swaagie/minimize), run on the top web pages. [See the breakdown here.](./bench)
Comparison with [html-minifier](https://github.com/kangax/html-minifier) and [minimize](https://github.com/Swaagie/minimize), run on the top web pages. [See the breakdown here.](./bench)

<img width="400" alt="Chart showing speed of HTML minifiers" src="https://wilsonl.in/minify-html/bench/0.8.1/core/average-speeds.png"><img width="400" alt="Chart showing compression of HTML minifiers" src="https://wilsonl.in/minify-html/bench/0.8.1/core/average-sizes.png">

Expand Down

0 comments on commit fd60983

Please sign in to comment.