[4.0] Update the help output and comments of the deleted file check to folder use #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
So the problem is this does need to move back to git commit references :) that’s the missing part of my current PR that blocks it from being merged |
Author
|
@wilsonge So this PR is wrong and I shall close it? Please confirm, then I'll close. But if so, then the help texts at following 2 places are wrong: Or do I understand something wrong still? |
Owner
|
Sorry for not replying. Yes the help texts should be updated as we work on the move back to use git properly |
Author
|
Then take this PR as a reminder. Or should I make a new one here? |
Owner
|
Can do a new one to fix that other text if you want sure |
wilsonge
pushed a commit
that referenced
this pull request
Dec 3, 2020
… and clean up sub-layouts (#45) * Separate link and button for dropdown items - Move dropdown handling to main layout override - Remove obsolete sub-layout overrides * Use language string for screenreader text * Add missing language string for frontend * Adapt metismenu scss to changed dropdown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for joomla#25559.
Summary of Changes
When a parameter is missing, the help message which is shown in that case still talks about commit references to be used and not folders or directories.
I've deficed to use the wording "directory" at the end because in some help messages for missing parameters it was already used like this.
Some code comments do the same.
Testing Instructions
Code review.
Expected result
Correct comments and help output.
Actual result
Misleading comments and help output.
Documentation Changes Required
None.