Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BYOND 515.1633 compat (incl. breakpoints!) #84

Merged
merged 3 commits into from
Mar 10, 2024
Merged

Conversation

Absolucy
Copy link
Collaborator

Credit to @Dimach for most of this; I just optimized the union stuff a bit and am going to push a release

Proof(?)

2024-03-10 (1710054488) ~ Code
2024-03-10 (1710054478) ~ Code
2024-03-10 (1710054464) ~ Code

commit b6c3ce4
Author: Dimach <[email protected]>
Date:   Sat Mar 9 00:45:53 2024 +0000

    rewrite using unions

commit fa0b19f
Author: Dimach <[email protected]>
Date:   Sat Feb 10 13:53:44 2024 +0200

    Update procs.rs

commit 4aef414
Author: Dimach <[email protected]>
Date:   Sat Feb 10 00:52:23 2024 +0200

    Signature for 1630
@Absolucy
Copy link
Collaborator Author

go go gadget self-merge

@Absolucy Absolucy merged commit fdacde2 into willox:master Mar 10, 2024
1 of 2 checks passed
@Absolucy Absolucy changed the title BYOND 515.1632 compat (incl. breakpoints!) BYOND 515.1633 compat (incl. breakpoints!) Mar 10, 2024
@Absolucy
Copy link
Collaborator Author

ignore my brainfart, it works with 1633, not just 1632

@Absolucy Absolucy deleted the 1630 branch March 10, 2024 07:16
@willox
Copy link
Owner

willox commented Mar 10, 2024

What's the #[inline(never)] for?

@Absolucy
Copy link
Collaborator Author

prolly not needed, but the idea was just like, it should just be a check and then an immediate jump to the correct version on the func. prolly me just overthinking things, tho.

@willox
Copy link
Owner

willox commented Mar 10, 2024

i feel like marking a single field access as non-inline is the most against-the-grain premature optimization i've ever seen but i'm not gonna change it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants