support for few items #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmurph
pushed a commit
to fgabelmannjr/ouroboros
that referenced
this pull request
Apr 18, 2018
I manually merged this from: willowtreeapps#41 Currently, when we try to run the carousel with a single item we’ll crash with the following precondition: ``` precondition(count >= buffer, "Ouroboros requires at least twice the number of items per page to work properly. For best results: a number that is evenly divisible by the number of items per page.") ``` Infinite scrolling is essentially the reason it didn’t work before. There’s no way to do that with a single item. He added support for non-infinite scroll. It took a lot of work to manually merge in his changes with Fredricks and with what was different on the origin repo. There were too many conflicts to do it automatically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added some changes to handle the case in which the number of items is less than the number of items needed to show an infinite scroll, being that if the number of items is smaller then the collection will behave like any other collection upon reaching the latest
also add the license at the beginning of the file (I think this is a good practice) and also delete some blank spaces