-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kinda major update #16
Conversation
src/run.bat
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[line 2] windows terminal minimizing problem fix (by using good ol' conhost - the classic command line window manager)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
even if they fix it i wouldnt recommend removing it, because some people might have the version with the problem and apart from that it doesnt really affect anything
Thank you for this! I'll take time to test this on my machine before being merged. Let me know when it's ready. |
Thanks you for the update, but kindly consider these important changes if u can include them.
|
|
@willnode ok, i tested it but i had to change some things. also, do you want me to implement the vbs method of hiding the window? it hides the window before it appears, unlike with the powershell one. if you feel like you dont need it, you can merge now |
yeah i think its better to implement the vbs method because its ugly to see a console window on startup |
@willnode you can merge now, i added the vbs hiding method and its way better |
wait, theres a dark version of the animation! i will implment it on a separate pr after this one is merged |
Co-authored-by: Wildan M <[email protected]>
could you make a new release please? |
Will do it in a few moments 👍 |
k nice |
dont forget to exclude the .git folder |
it goes to github.com/willnode/autobloom/blob/master/willnode/pull/16 sometimes (kek)
it goes to `github.com/willnode/autobloom/blob/master/willnode/pull/16` sometimes (kek)
notes (MUST READ)
the ch/conhost argument check/run on the second line of run.bat is a workaround to the problem that hiding the window (new method) doesnt work with windows terminal (it minimizes instead of hiding)
there is another way of starting the file hidden with vbs, but it only saves a bit of time, not too much. if you want anyways, i will be more than happy to implement it; its very simple and short (TELL ME BEFORE MERGING!)
i also want to pass the mpv.conf to mpv args, which i will do today; please wait for it before merging (TESTING)
please confirm that you saw this, else i wont know
no more antivirus bs