Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kinda major update #16

Merged
merged 25 commits into from
Apr 10, 2023
Merged

kinda major update #16

merged 25 commits into from
Apr 10, 2023

Conversation

eltrevii
Copy link
Collaborator

@eltrevii eltrevii commented Apr 8, 2023

notes (MUST READ)

  1. the ch/conhost argument check/run on the second line of run.bat is a workaround to the problem that hiding the window (new method) doesnt work with windows terminal (it minimizes instead of hiding)

  2. there is another way of starting the file hidden with vbs, but it only saves a bit of time, not too much. if you want anyways, i will be more than happy to implement it; its very simple and short (TELL ME BEFORE MERGING!)

  3. i also want to pass the mpv.conf to mpv args, which i will do today; please wait for it before merging (TESTING)

  4. please confirm that you saw this, else i wont know

  5. no more antivirus bs

This was unlinked from issues Apr 8, 2023
This was linked to issues Apr 8, 2023
src/run.bat Outdated
Copy link
Collaborator Author

@eltrevii eltrevii Apr 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[line 2] windows terminal minimizing problem fix (by using good ol' conhost - the classic command line window manager)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even if they fix it i wouldnt recommend removing it, because some people might have the version with the problem and apart from that it doesnt really affect anything

@eltrevii eltrevii changed the title big update kinda major update Apr 8, 2023
@willnode
Copy link
Owner

willnode commented Apr 9, 2023

Thank you for this! I'll take time to test this on my machine before being merged. Let me know when it's ready.

@askfriends
Copy link

Thanks you for the update, but kindly consider these important changes if u can include them.

  1. Add dark theme support
  2. The bloom should run in reverse order when logging off or shutting down pc.
  3. Add more wallpapers like this.

@eltrevii
Copy link
Collaborator Author

eltrevii commented Apr 9, 2023

@askfriends

  1. we cannot add dark theme because the animation was made by microsoft and they didnt make the dark theme version afaik
  2. we cannot know when the computer shuts down/user logs off or stop the shutdown/logoff before playing the animation
  3. we would need to find all the animations and its not an easy process

@eltrevii
Copy link
Collaborator Author

eltrevii commented Apr 9, 2023

@willnode ok, i tested it but i had to change some things. also, do you want me to implement the vbs method of hiding the window? it hides the window before it appears, unlike with the powershell one. if you feel like you dont need it, you can merge now
ill keep committing until you merge if i need to change more stuff but you can merge anytime

@eltrevii
Copy link
Collaborator Author

eltrevii commented Apr 9, 2023

yeah i think its better to implement the vbs method because its ugly to see a console window on startup

@eltrevii
Copy link
Collaborator Author

eltrevii commented Apr 9, 2023

@willnode you can merge now, i added the vbs hiding method and its way better
i also updated the readme.md with a new demonstration video

@eltrevii
Copy link
Collaborator Author

eltrevii commented Apr 9, 2023

wait, theres a dark version of the animation! i will implment it on a separate pr after this one is merged

install.bat Show resolved Hide resolved
Co-authored-by: Wildan M <[email protected]>
@willnode willnode merged commit c10a562 into willnode:master Apr 10, 2023
@eltrevii
Copy link
Collaborator Author

could you make a new release please?

@willnode
Copy link
Owner

Will do it in a few moments 👍

@eltrevii
Copy link
Collaborator Author

k nice

@eltrevii
Copy link
Collaborator Author

eltrevii commented Apr 10, 2023

dont forget to exclude the .git folder

eltrevii added a commit to eltrevii/autobloom that referenced this pull request Jul 20, 2023
it goes to github.com/willnode/autobloom/blob/master/willnode/pull/16 sometimes (kek)
@eltrevii eltrevii mentioned this pull request Jul 20, 2023
eltrevii added a commit to eltrevii/autobloom that referenced this pull request Jul 20, 2023
it goes to `github.com/willnode/autobloom/blob/master/willnode/pull/16` sometimes (kek)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants