Skip to content

[eventhubs-checkpointstore-blob] fix build:samples script #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
willmtemple merged 1 commit into from
Dec 2, 2020
Merged

[eventhubs-checkpointstore-blob] fix build:samples script #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sdk/eventhub/eventhubs-checkpointstore-blob/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"audit": "node ../../../common/scripts/rush-audit.js && rimraf node_modules package-lock.json && npm i --package-lock-only 2>&1 && npm audit",
"build:browser": "tsc -p . && cross-env ONLY_BROWSER=true rollup -c 2>&1",
"build:node": "tsc -p . && cross-env ONLY_NODE=true rollup -c 2>&1",
"build:samples": "echo Skipped.",
"build:samples": "dev-tool samples prep && cd dist-samples && tsc",
"build:test:browser": "tsc -p . && cross-env ONLY_BROWSER=true rollup -c rollup.test.config.js 2>&1",
"build:test:node": "tsc -p . && cross-env ONLY_NODE=true rollup -c rollup.test.config.js 2>&1",
"build:test": "npm run build:test:node",
Expand Down Expand Up @@ -66,6 +66,7 @@
"tslib": "^2.0.0"
},
"devDependencies": {
"@azure/dev-tool": "^1.0.0",
"@azure/eslint-plugin-azure-sdk": "^3.0.0",
"@microsoft/api-extractor": "7.7.11",
"@rollup/plugin-commonjs": "11.0.2",
Expand Down
2 changes: 1 addition & 1 deletion sdk/eventhub/eventhubs-checkpointstore-blob/samples/typescript/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
},
"dependencies": {
"@azure/event-hubs": "^5.0.2",
"@azure/eventhubs-checkpointstore-blob": "^1.0.0",
"@azure/eventhubs-checkpointstore-blob": "latest",
"@azure/storage-blob": "^12.1.1",
"dotenv": "^8.2.0",
"tslib": "^1.9.3"
Expand Down
4 changes: 2 additions & 2 deletions ...venthubs-checkpointstore-blob/samples/typescript/src/receiveEventsUsingCheckpointStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const storageConnectionString = "";
const containerName = "";
const consumerGroup = "";

async function main() {
export async function main() {
// this client will be used by our eventhubs-checkpointstore-blob, which
// persists any checkpoints from this session in Azure Storage
const containerClient = new ContainerClient(storageConnectionString, containerName);
Expand Down Expand Up @@ -74,7 +74,7 @@ async function main() {
);
},
processError: async (err, context) => {
console.log(`Error : ${err}`);
console.log(`Error on partition "${context.partitionId}": ${err}`);
}
});

Expand Down
4 changes: 2 additions & 2 deletions ...nthubs-checkpointstore-blob/samples/typescript/src/receiveEventsWithApiSpecificStorage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ const storageContainerUrl =
const storageAccountName = process.env["STORAGE_ACCOUNT_NAME"] || "<storageaccount>";
const storageAccountKey = process.env["STORAGE_ACCOUNT_KEY"] || "<key>";

async function main() {
export async function main() {
// The `containerClient` will be used by our eventhubs-checkpointstore-blob, which
// persists any checkpoints from this session in Azure Storage.
const storageCredential = new StorageSharedKeyCredential(storageAccountName, storageAccountKey);
Expand Down Expand Up @@ -78,7 +78,7 @@ async function main() {
);
},
processError: async (err, context) => {
console.log(`Error : ${err}`);
console.log(`Error on partition "${context.partitionId}": ${err}`);
}
});

Expand Down