fixed tests for min and max#4
Merged
williamma12 merged 2 commits intowilliamma12:fix_testsfrom Oct 13, 2018
Merged
Conversation
williamma12
requested changes
Oct 13, 2018
modin/pandas/test/test_dataframe.py
Outdated
| with pytest.raises(TypeError): | ||
| modin_result = modin_df.max(axis=axis, skipna=skipna, numeric_only=numeric_only) | ||
| return | ||
| modin_result = modin_df.max(axis=axis, skipna=skipna, numeric_only=numeric_only) |
Owner
There was a problem hiding this comment.
can this part be moved to the try block so we wont have an empty return statement?
Author
There was a problem hiding this comment.
The return is so that execution doesn't move to the next line (which raises an error without being caught, causing the test to fail). Moving the return statement to the try doesn't prevent this so the tests will still show up as failed.
Owner
There was a problem hiding this comment.
Not the return statement but the stuff below the return statement into the try block?
Author
There was a problem hiding this comment.
ah yeah you're right - updated the PR!
modin/pandas/test/test_dataframe.py
Outdated
| with pytest.raises(TypeError): | ||
| modin_result = modin_df.min(axis=axis, skipna=skipna, numeric_only=numeric_only) | ||
| return | ||
| modin_result = modin_df.min(axis=axis, skipna=skipna, numeric_only=numeric_only) |
williamma12
approved these changes
Oct 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests for min and max should expect TypeError to be raised for invalid input combinations - this PR adds this to the tests.