use browser built-in options_ui #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since we are already in the context of the extension and the logo and title of the extension would already be in view. the logo and header within the `options_ui` would only make it redundant.
we use both `<select>` and `<button>` that require the additional CSS class `browser-style` to be specified in the element itself for it to inherit the `browser_style`. reference : https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Browser_styles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening the extension's
options_uiin a separate tab is an oldmethod. Browsers now provide a built-in
options_uiwithin theExtension's listing page itself.
This changeset changes the
options_uibehaviour to open within theextension's listing context itself.
This can also avoid confusions like issue #35. I myself had the same
confusion on Firefox. On Chrom{e,ium}, at least, there is a default
button on the toolbar which the user can click and find the 'Options'
page. On Firefox, there is none. Finding the 'Preferences' option
within the overflow menu of the extension is too far-fetched to find.
I got to #35 searching for how to change the theme on Firefox.
Resolves #35