Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Lightning compatibility with PyTorch 1.2.0 #79

Closed
williamFalcon opened this issue Aug 8, 2019 · 10 comments
Closed

Update Lightning compatibility with PyTorch 1.2.0 #79

williamFalcon opened this issue Aug 8, 2019 · 10 comments
Labels
feature Is an improvement or enhancement help wanted Open to be worked on

Comments

@williamFalcon
Copy link
Contributor

Is your feature request related to a problem? Please describe.
PyTorch 1.2.0 has breaking changes for the experiment object.
Likely underlying changes to SummaryWriter.

For now, Lightning requires pytorch 1.1.0 but need to update compatibility.

@williamFalcon williamFalcon added feature Is an improvement or enhancement help wanted Open to be worked on labels Aug 8, 2019
@williamFalcon
Copy link
Contributor Author

williamFalcon commented Aug 8, 2019

@Borda apparently 1.2.0 came out a few hours ago which is breaking the summaryWriter... fixed the pytorch version for now to 1.1.0 unitl i sort that out (thus the 0.4.1 update...)

@cwerner
Copy link

cwerner commented Aug 8, 2019

Hm, I just downgraded torch to 1.1 but I still have problems with Experiment. I'm not getting any output for TensorBoard. Are there some more examples I could look at?

@williamFalcon
Copy link
Contributor Author

you’re probably on a jupyter notebook. tensorbord and jupyter have issues

@cwerner
Copy link

cwerner commented Aug 8, 2019

I am indeed. Bummer... So no jupyterlab + TensorBoard for now?

@williamFalcon
Copy link
Contributor Author

@cwerner yeah, maybe in this new version PT just released. update to 1.2.0 and lighting 0.4.2 to see what happens. they changed summaryWriter quite a bit

@cwerner
Copy link

cwerner commented Aug 8, 2019

Cool. Will do. Thanks 🙏

@Borda
Copy link
Member

Borda commented Aug 8, 2019

Sorry, I don't have connection now..

@cwerner
Copy link

cwerner commented Aug 9, 2019

@williamFalcon just a heads-up. Still no output in Lightning, but it get tb output if I use summarywriter directly in my PyTorch Code from jupyterlab (on Port 6006, not in the extension). Could be that I do miss something in the lightning code?!

@williamFalcon
Copy link
Contributor Author

@cwerner ok, i need to look into this bc Experiment IS a SummaryWriter as well.

Can you post code with both?

But at a minimum i can make it so SummaryWriter can just be used directly. That way we can start the process to support other loggers.

@cwerner
Copy link

cwerner commented Aug 9, 2019

Will be of my machine for a few days but will update and try. If I still have issues I’ll post some code here...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement help wanted Open to be worked on
Projects
None yet
Development

No branches or pull requests

3 participants