Implement getOrderedElements() #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm... Seems that PHP 5 and PHP 7 order differently when equal… |
|
😞 |
|
Reading the logs, I think the AppVeyor build has failed due to an installation issue rather than anything to do with this change. |
|
This also merges cleanly to the |
|
Yep, I don't get why it fails actually. Investigating right now... |
|
Hi @akrabat, could you please rebase your branch so that we can ensure it passes on Appveyor too? I fixed the build (in theory). |
This method retrieves the elements of the given Accept/Accept-* header as an array ordered with the most preferred first. Fixes willdurand#75
akrabat
force-pushed
the
get-ordered-elements
branch
from
e3f11a3 to
57e02a2
Compare
|
Rebased |
|
@willdurand There we go! Thanks for fixing Appveyor 👍 |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method retrieves the elements of the given Accept/Accept-* header as an array ordered with the most preferred first.
Fixes #75