Polish validator 2 --- self readcodes. by will-2012 · Pull Request #34 · will-2012/reth-bsc

will-2012 · 2025-09-08T06:24:01Z

Description

add a description of your changes here...

Rationale

tell us why we need these changes...

Example

add an example CLI or API response...

Changes

Notable changes:

add each change in a bullet point here
...

Potential Impacts

add potential impacts for other components here
...

)

* chore: polish trival by failed action * chore: polish trival

* feat: succeed to mine block * feat: mine block but receive the RecoverECDSAInnerError * remove useless code

will-2012 · 2025-09-08T06:24:51Z

examples/generate_mining_keys.rs

@@ -0,0 +1,33 @@
+#!/usr/bin/env cargo


生成私钥.

will-2012 · 2025-09-08T06:38:29Z

src/consensus/parlia/consensus.rs

+        if left_over_ms >= period_ms {
+            warn!("Delay invalid argument: left_over_ms={}, period_ms={}", left_over_ms, period_ms);
+        } else if left_over_ms >= delay_ms {
+            delay_ms = 0;


return ??

https://github.com/bnb-chain/bsc/blob/fca6a6bee850b226938d2f2a990afab3246efc1e/consensus/parlia/parlia.go#L1654

will-2012 · 2025-09-08T06:44:12Z

src/consensus/parlia/seal.rs

-
-    pub fn seal(self, block: BscBlock) -> Result<SealedBlock<BscBlock>, ConsensusError> {
+    pub fn seal(&self, block: BscBlock) -> Result<SealedBlock<BscBlock>, ConsensusError> {
        let header = block.header();


refer to https://github.com/bnb-chain/bsc/blob/fca6a6bee850b226938d2f2a990afab3246efc1e/consensus/parlia/parlia.go#L1672

will-2012 · 2025-09-08T06:46:15Z

src/consensus/parlia/snapshot.rs


+    /// Returns true if `block_number` is the last block of the current turn window.
+    /// When turn_length is 1 (pre-Bohr), every block is considered last in turn.
+    pub fn last_block_in_one_turn(&self, block_number: u64) -> bool {


refer to https://github.com/bnb-chain/bsc/blob/master/consensus/parlia/snapshot.go#L448.

will-2012 · 2025-09-08T07:20:10Z

src/node/engine.rs

+        + Sync
+        + 'static,
+{
+    pub fn new(


关注下什么地方调用的.

will-2012 · 2025-09-08T11:14:15Z

src/node/engine.rs

+    }
+
+    /// Collect transactions from the transaction pool
+    async fn collect_transactions(


参考payload builder实现

will-2012 · 2025-09-08T11:15:15Z

src/node/network/mod.rs

+        let handle = ImportHandle::new(to_import.clone(), import_outcome);
+
+        // Expose the sender globally so that the miner can submit newly mined blocks
+        if crate::shared::set_block_import_sender(to_import.clone()).is_err() {


block broadcast channel?

will-2012 · 2025-09-08T11:16:03Z

src/node/engine_api/validator.rs

+
        let expected_hash = block.header.hash_slow();
-        let sealed_block = block.seal_slow();
+        let sealed_block = match &self.sealed_block {


错了，todo revert.

will-2012 · 2025-09-08T11:54:10Z

MINING.md

+
+### Transaction Collection
+
+- Fetches best transactions from the transaction pool


是不是需要模拟执行？？ --- 看看eth怎么搞的

注意system tx.

这个过程，正常还需要监听最新head.

ctx.provider().canonical_state_stream() 监听head逻辑？

will-2012 · 2025-09-08T11:55:15Z

MINING.md

+
+- Fetches best transactions from the transaction pool
+- Respects block gas limit constraints
+- Currently simplified - full transaction processing to be implemented


什么意思？

will-2012 · 2025-09-08T12:00:34Z

MINING.md

+
+### 1. Transaction Processing
+```rust
+// TODO: Implement proper transaction cloning based on transaction type


关注这几个todo... 其实想的很清楚了.

will-2012 · 2025-09-08T12:03:21Z

MINING.md

+2. Calculate optimal mining time based on turn
+3. Collect transactions from pool
+4. Build and seal block using Parlia consensus
+5. Submit block (when implemented)


可能需要交给引擎api，内部有最长链判断等等 --- 将来这部分也需要修改，FF有些判定、reorg等逻辑貌似也在这部分..并且与eth是有差异的.

will-2012 · 2025-09-08T12:05:09Z

MINING.md

+
+### With reth-bsc Components
+
+- **Engine API**: Integrates with `BscPayloadServiceBuilder`


不一定需要吧 --- 具体看build payload是自己实现，还是依赖engine-api下的payload builder. 貌似大概率，应该自己实现，因为和system tx等等相关？？？--- 再想想

will-2012 · 2025-09-08T12:05:45Z

MINING.md

+### With reth-bsc Components
+
+- **Engine API**: Integrates with `BscPayloadServiceBuilder`
+- **Consensus**: Uses existing Parlia consensus logic


逻辑补全，缺各种prepare、seal等逻辑

will-2012 · 2025-09-08T12:07:06Z

MINING.md

+## Next Steps
+
+1. **Complete Transaction Integration**: Implement proper transaction collection and processing
+2. **Block Submission**: Connect to engine API or direct chain import


对是个问题；大概率走engine-api. 不然最长链判断、内存状态维护等等，那一坨逻辑是相当多的.

will-2012 · 2025-09-08T12:12:36Z

MINING.md

+
+🚧 **In Progress**:
+- Configuration file loading
+- Transaction processing


主体还是要参考 default_ethereum_payload !!!

will-2012 · 2025-09-08T12:12:47Z

MINING.md

+🚧 **In Progress**:
+- Configuration file loading
+- Transaction processing
+- Block submission to chain


will-2012 · 2025-09-08T12:19:20Z

MINING_QUICKSTART.md

+
+## 🚨 Important Notes
+
+- **Auto-generated keys are for DEVELOPMENT only**


will-2012 · 2025-09-08T12:19:55Z

MINING_QUICKSTART.md

+
+- **Auto-generated keys are for DEVELOPMENT only**
+- **Save the generated keys if you want to reuse the same validator identity**
+- **Mining will work but blocks may not be accepted without proper validator registration**


对于测试，我理解这个就够用了.

will-2012 · 2025-09-08T12:24:15Z

src/main.rs

+
+    /// Use development chain with auto-generated validators
+    #[arg(long = "bsc-dev")]
+    pub dev_mode: bool,


和mining_dev的区别是？

will-2012 · 2025-09-08T12:25:57Z

src/main.rs

+
+    /// Auto-generate development keys for mining
+    #[arg(long = "mining.dev")]
+    pub mining_dev: bool,


remove it. todo.

will-2012 · 2025-09-08T12:27:02Z

src/main.rs

+                if let Some(ref pk_hex) = args.private_key {
+                    mining_config.private_key_hex = Some(pk_hex.clone());
+                    // Derive validator address from provided key
+                    if let Ok(sk) = mining_config::keystore::load_private_key_from_hex(pk_hex) {


这步是什么意思？

will-2012 · 2025-09-08T12:28:02Z

src/node/engine.rs

+/// Mining Service that handles block production for BSC
+pub struct BscMiner<Pool, Provider> {
+    pool: Pool,
+    provider: Provider,


这俩字段最重要. 重点关注.

will-2012 · 2025-09-08T12:34:57Z

src/node/engine.rs

+                return Err("No signing key configured".into());
+            };
+
+            // Derive validator address from the signing key and prefer it


怎么理解这个含义？

will-2012 · 2025-09-08T12:35:21Z

src/node/engine.rs

+        }
+
+        // Ensure the genesis block header is cached so that the snapshot provider can create the genesis snapshot
+        {


临时的mock，不该这样.

will-2012 · 2025-09-08T12:43:25Z

src/node/engine.rs

+
+                info!("Snapshot provider available, starting BSC mining service");
+
+                match BscMiner::new(


嗯？在这里？？

放在这里，整体上面感觉不太对头。临时的，再think think.

will-2012 · 2025-09-08T12:44:08Z

src/node/pooled_tx.rs

@@ -0,0 +1,90 @@
+// TODO: tmp mock, and will remove it later.


will-2012 · 2025-09-08T12:59:20Z

src/main.rs

+                mining_config = mining_config.ensure_keys_available();
+
+                // Best-effort set; ignore error if already set
+                if let Err(_boxed_config) = mining_config::set_global_mining_config(mining_config) {


仅仅是set一个全局的配置？

will-2012 · 2025-09-08T13:05:30Z

src/node/engine.rs

+        + 'static,
    Evm: ConfigureEvm,
 {
    async fn spawn_payload_builder_service(


看下eth的这个函数做了什么

will-2012 · 2025-09-08T13:06:09Z

src/node/engine.rs

        self,
        ctx: &BuilderContext<Node>,
-        _pool: Pool,
+        pool: Pool,


_evm参数不该没用吧?

jhgdike and others added 11 commits September 3, 2025 14:59

feat: seal block with signing_key

7e12a8b

remove redundant code

955e85f

try get signed tx from txpool

b9cc800

feat: seal block in the validator

a6e0fae

feat: import block to local and network

2d9f066

feat: add support of miner engine

0f2c82b

feat: seal block before ensure_well_formed_payload

0fa5978

feat: add a init genesis_local.json to pass the cargo check (loocapro#37

901229b

)

feat: use TransactionSigned Pool (loocapro#38)

295b77e

chore: polish some trivals by failed action (loocapro#39)

61e7f54

* chore: polish trival by failed action * chore: polish trival

Dike miner (loocapro#41)

a9efeba

* feat: succeed to mine block * feat: mine block but receive the RecoverECDSAInnerError * remove useless code

will-2012 marked this pull request as draft September 8, 2025 06:24

will-2012 changed the title ~~Polish validator 2 --- readcodes.~~ Polish validator 2 --- self readcodes. Sep 8, 2025