[WFARQ-160] Propagate JUnit 'failed assumption' exception types from … #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ServerSetupObserver
jamezp
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ServerSetupObserver
https://issues.redhat.com/browse/WFARQ-160
Note there are a couple of TODO comments in ServerSetupObserver, which relate to the JUnit 5 'org.opentest4j.TestAbortedException' class. That is its analogue to the JUnit 4 'org.junit.AssumptionViolatedException' that I deal with here. I left handling that as a TODO because JUnit 5 still handles 'AssumptionViolatedException' if test code throws it. So, ServerSetupTask implementors being able to throw TestAbortedException is more of a nice-to-have.
That said, the code to handle TestAbortedException is probably all there; just a couple lines need uncommenting. The test infrastructure to test it is also mostly there. I just don't have time now to actually set up tests that use @ExtendWith(ArquillianExtension.class) etc.