[WFSSL-74] Update the error message that occurs when OpenSSLEngine#closeInbound is called before receiving the close_notify message from the peer so that it's consistent with the JDK SSLEngine #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oseInbound is called before receiving the close_notify message from the peer so that it's consistent with the JDK SSLEngine
Skyllarr
approved these changes
May 18, 2021
darranl
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/WFSSL-74
As described in WFSSL-74, some Infinispan tests make use of Netty's
SslHandler. WhenSslHandler#setHandshakeFailureis called, it is supposed to swallow anSSLExceptionafter callingcloseInboundif this is called before receiving theclose_notifymessage from the peer (it's ok to swallow the exception in this case because the connection is about to be closed). To determine whether or not the exception should be swallowed, Netty'sSslHandleris looking for a specific string that matches the error message thrown by the JDKSSLEngine.This PR updates our error message in this case so that it is consistent with the JDK's error message.