Logout ely 2534 #2249
Logout ely 2534 #2249
Conversation
…ck-channel logout
…an active session
…ing doesn't rely on an active session and ensure the session will get invalidated appropriately upon subsequent requests
…validation check to before the authenticator#authenticate call and update the check to not remove the session from the map to ensure that the user gets logged out from any other apps too
… the sessionsMarkedForInvalidation map
rsearls
force-pushed
the
logout-ELY-2534
branch
from
c66c9ab to
b3ffe0f
Compare
rsearls
force-pushed
the
logout-ELY-2534
branch
from
1123a7f to
bbc858c
Compare
There was a problem hiding this comment.
LGTM overall! One small improvement could be adjusting the debug message to match the format of other log statements. For instance, instead of:
log.debug("evaluateRequest uri: " + request.getRequestURI().toString());You might consider using log.debugf for consistency:
log.debugf("The evaluated request URI is [%s]", request.getRequestURI().toString());This keeps the style aligned with existing logs, like:
log.debugf("Ignoring request for path [%s] from mechanism [%s]. No client configuration context found." ...);That said, this is a minor improvement — everything else looks great to me!
| private static final String POST_LOGOUT_REDIRECT_URI_PARAM = "post_logout_redirect_uri"; | ||
| private static final String ID_TOKEN_HINT_PARAM = "id_token_hint"; | ||
| private static final String LOGOUT_TOKEN_PARAM = "logout_token"; | ||
| private static final String LOGOUT_TOKEN_TYPE = "Logout"; |
There was a problem hiding this comment.
"Logout" with the first capital letter is the expected value?
There was a problem hiding this comment.
Yes "Logout" is expected it looks to be a key for claim types. similarly "Bearer" is capitalized as well.
I changed the log.debug ref to log.debugf only in the code I added. I prefer to leave pre-existing code as is.
Thanks for the code review and the suggestions.
https://issues.redhat.com/browse/ELY-2534
supersede #2245