Remove metrics endpoints #1348
Merged
Remove metrics endpoints #1348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that these endpoints are provided through AQS 2.0 and the REST gateway, we no longer need to include them as part of the RESTBase docs, configuration, or tests.
apaskulin
force-pushed
the
remove-metrics
branch
from
2ea3cbe
to
d86832b
Compare
|
@nosmo, Looks like this passed CI, but I wasn't able to test it locally to confirm that it correctly removes the metrics endpoints. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the
/metricsendpoints now provided through AQS 2.0 and the REST gateway, they no longer need to be included in the RESTBase docs at https://wikimedia.org/api/rest_v1/#/This PR attempts to remove the
/metricsendpoints from the docs by removing the paths from the specs, configuration, and tests. Note that this PR is risky since it includes major changes, and I wasn't able to test it locally to ensure that it works correctly. Feel free to close if it's too risky to merge.