Fix and make a release that works on PHP 8.0

[dleffler]

Under PHP v8.0.0
Deprecated: Required parameter $rules follows optional parameter $value in K:\UwAmp\www\exp2\external\less.php\lib\Less\Tree\Directive.php on line 20

Currently
public function __construct($name, $value = null, $rules, $index = null, $currentFileInfo = null, $debugInfo = null ){

Possible fix
public function __construct($name = null, $value = null, $rules = null, $index = null, $currentFileInfo = null, $debugInfo = null ){

[xmorave2]

Fixed in #34

[jdforrester]

I've made a start with another fix in #53.

[jdforrester]

Release v3.1.0 is now out on packagist.org etc.

[sgiehl]

@jdforrester Thanks for the release. Is there any specific reason v3 requires PHP 7.2.9.
We're using the lib in a project requiring PHP 7.2.5 and we can't easily adjust the requirement without a major release, which won't happen soon. Wondering if there might be any issue when using it on PHP 7.2.5 nevertheless 🤔

[jdforrester]

Hey there,

Sorry about that. We bumped MediaWiki's dependency on PHP 7.2.x to 7.2.9 to work around a few segfaults in PHP that got fixed upstream, and so as general practice we apply that to all our libraries, rather than pretend that we thing 7.2.0 is safe, and that's what I did in 28baca4. (Note that we ran into another segfault and had to raise it again to 7.2.22 for https://phabricator.wikimedia.org/T228346.)

In practice, I imagine the segfaults aren't likely to be an issue for your library either, so you can bypass the restriction if you need to.

[dleffler]

I'm able to use the current version 3.1.0 on php v5.6 with only a change to the Version,php file removing the 'public' from the 3 const lines