Skip to content

Espresso Suggested Edit Test #5148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 3, 2024

Conversation

Williamrai
Copy link
Collaborator

@Williamrai Williamrai commented Nov 21, 2024

What does this do?

Adds espresso test for suggested edit screen.

In order for login to work, you would need to set the username and password on the environment variable. You would need to set this variable with the username and password.
TEST_LOGIN_USERNAME = ""
TEST_LOGIN_PASSWORD = "

Phabricator:
https://phabricator.wikimedia.org/T378655

…ide a nested scroll view

- adds a data class called DataInjector which will helps us to easily add data to activities instead of creating multiple secondary constructor for BaseTest class
- adds an override contribution developer preference setting
- adds all the test cases from the QTE doc
@Williamrai Williamrai added the Ready to merge PR passed design signoff and ready to be merged. label Nov 21, 2024
@Williamrai Williamrai changed the title - adds a function that will allow espresso to scroll recyclerview ins… Espresso Suggested Edit Test Nov 21, 2024
Copy link
Collaborator

@cooltey cooltey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test stops at the login screen. The username and password are incorrect.

@Williamrai
Copy link
Collaborator Author

The test stops at the login screen. The username and password are incorrect.

I forgot to mention this, we need to set the username and password on the env variable locally. We have code in the build.gradle where it would take value from the config file.

def TEST_LOGIN_USERNAME = System.getenv('TEST_LOGIN_USERNAME') def TEST_LOGIN_PASSWORD = System.getenv('TEST_LOGIN_PASSWORD') buildConfigField "String", "TEST_LOGIN_USERNAME", TEST_LOGIN_USERNAME != null ? "\"${TEST_LOGIN_USERNAME}\"" : '"Foo"' buildConfigField "String", "TEST_LOGIN_PASSWORD", TEST_LOGIN_PASSWORD != null ? "\"${TEST_LOGIN_PASSWORD}\"" : '"Bar"'

@cooltey cooltey merged commit b714ff4 into espresso-test-main Dec 3, 2024
1 check passed
@cooltey cooltey deleted the espresso-suggested-edit-test branch December 3, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge PR passed design signoff and ready to be merged.
Development

Successfully merging this pull request may close these issues.

2 participants