-
-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Espresso test explore feed #5130
Open
Williamrai
wants to merge
17
commits into
espresso-test-main
Choose a base branch
from
espresso-test-explore-feed
base: espresso-test-main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the function scrolls based on title of the card, removes position as the scroll factor - adds two scrollToViewMainPageAndClick and scrollToCardWithTitleAndClick function - the function can also take viewId
- fixes scroll to View with title by adding an offset which would allow espresso to click effectively - adds the flow for espresso test from the QTE document
- refactors scroll and click function - adds all the flow for Explore Feed from QTE doc - adds try catch for conditional execution
Williamrai
added
Ready to merge
PR passed design signoff and ready to be merged.
and removed
WIP
Work in progress
labels
Nov 19, 2024
cooltey
reviewed
Nov 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got the error on the notification icon:
11-21 00:30:37.308 14880 14982 E TestRunner: at org.wikipedia.base.BaseRobot.clickOnDisplayedViewWithIdAnContentDescription(BaseRobot.kt:77)
11-21 00:30:37.308 14880 14982 E TestRunner: at org.wikipedia.robots.screen.HomeScreenRobot.navigateToNotifications(HomeScreenRobot.kt:27)
11-21 00:30:37.308 14880 14982 E TestRunner: at org.wikipedia.test.loggedoutuser.ExploreFeedTest.startExploreFeedTest(ExploreFeedTest.kt:134)
11-21 00:30:37.308 14880 14982 E TestRunner: at java.lang.reflect.Method.invoke(Native Method)
11-21 00:30:37.308 14880 14982 E TestRunner: at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
11-21 00:30:37.308 14880 14982 E TestRunner: at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
11-21 00:30:37.308 14880 14982 E TestRunner: at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
11-21 00:30:37.308 14880 14982 E TestRunner: at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
# Conflicts: # app/src/androidTest/java/org/wikipedia/TestSuite.kt
Williamrai
removed
the
Ready to merge
PR passed design signoff and ready to be merged.
label
Nov 21, 2024
# Conflicts: # app/src/androidTest/java/org/wikipedia/tests/ExploreFeedTest.kt # app/src/androidTest/java/org/wikipedia/tests/SuggestedEditCardTest.kt # app/src/androidTest/java/org/wikipedia/tests/WatchListTest.kt
Williamrai
added
the
Ready to merge
PR passed design signoff and ready to be merged.
label
Nov 21, 2024
Hi @Williamrai I see this error messages:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
This refactors the scroll function for Feed recycler view and adds the QTE test flow.
Phabricator:
https://phabricator.wikimedia.org/T378651