Add temporal spectral community detection#94
Merged
wiheto merged 1 commit intowiheto:masterfrom Dec 11, 2025
Merged
Conversation
wiheto
requested changes
Dec 1, 2025
Owner
wiheto
left a comment
wiheto
left a comment
There was a problem hiding this comment.
Generally makes sense. The algorithm and everything looks cool. COuld you just clarify some of the document config changes.
| 'sphinx.ext.githubpages', | ||
| 'sphinx.ext.napoleon', | ||
| 'm2r', | ||
| 'myst_parser', |
Owner
There was a problem hiding this comment.
Whats the purpose of adding this in the documents?
Contributor
Author
There was a problem hiding this comment.
| # extensions coming with Sphinx (named 'sphinx.ext.*') or your custom | ||
| # ones. | ||
| extensions = [ | ||
| 'matplotlib.sphinxext.only_directives', |
Owner
There was a problem hiding this comment.
Not sure why this being removed? Was it redundant?
Contributor
Author
There was a problem hiding this comment.
Yes, I believe it is redundant, and indeed removed as of Matplotlib 3.0. I had to drop the extension to build the docs.
Owner
|
Seems good. Thanks for clarifying all the other changes. Let's get this merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement as discussed the spectral method for temporal community detection outlined in this paper (
teneto/communitydetection/spectral.py). Document indocs/teneto.communitydetection.rst.New dependency:
scikit-learn(used for KMeans and clusteringmetrics) declared in
requirements.txtandsetup.pyTesting:
pytest test/communitydetection/test_temporal_spectral.pyOther: switched from
m2rtomyst_parserfor docs (the former breaks on newer Sphinx versions). Requirematplotlib >= 3.8(also to make Sphinx happy)