Skip to content

Fix ComparisonConditionTypeHelper to convert only if value is a string #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025
Merged

Fix ComparisonConditionTypeHelper to convert only if value is a string #62

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/Avalonia.Xaml.Interactivity/Helpers/ComparisonConditionTypeHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,9 @@ public static bool Compare(object? leftOperand, ComparisonConditionType operator
{
if (leftOperand is not null && rightOperand is not null)
{
var rightOperandString = rightOperand.ToString();
var leftOperandType = leftOperand.GetType();
if (rightOperandString is not null)
if (rightOperand is string rightOperandString)
{
var leftOperandType = leftOperand.GetType();
var convertedRightOperand = TypeConverterHelper.Convert(rightOperandString, leftOperandType);
if (convertedRightOperand is not null)
{
Expand Down
Loading