Handle non-convertible data trigger values safely - #366
Merged
Merged
Conversation
wieslawsoltes
marked this pull request as ready for review
July 14, 2026 22:18
This was referenced Aug 21, 2026
This was referenced Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevents
DataTriggerBehaviorand shared comparison conditions from throwing when a stringValuecannot be converted to the runtime type ofBinding.Contract
A conversion or compatible-comparison failure now uses non-equal semantics:
NotEqualevaluates totrue.Equaland all relational operators evaluate tofalse.This lets dynamically generated or design-time-incomplete triggers remain inert until their values become compatible.
Root cause
The initial string conversion called
TypeConverterHelper.Convertwithout guarding its standard conversion failures. Primitive parsing such asint.Parsecould therefore propagateFormatExceptionorOverflowException.The later comparable path handled only part of the conversion surface and called
IComparable.CompareTowithout guarding incompatible-operand exceptions.Changes
Convert.ChangeType.ArgumentExceptionorInvalidCastExceptionfromCompareToas incompatible operands.IComparableimplementation that rejects the other operand.DataTriggerBehaviortest proving dispatcher evaluation neither throws nor executes actions.Unexpected exceptions outside these known conversion/comparison incompatibilities continue to propagate.
Validation
DataTriggerBehaviorregression: 1 passedXaml.Behaviors.Interactivity.UnitTests: 102 passedXaml.Behaviors.Interactions.UnitTests: 90 passed, 2 existing skippedgit diff --check: cleanCloses #346