Strong-name sign all packaged assemblies - #547
Merged
Merged
Conversation
wieslawsoltes
marked this pull request as ready for review
July 14, 2026 21:17
This was referenced Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Strong-name sign every first-party assembly currently shipped from a packable project.
This restores the repository's existing signing policy to the three Avalonia packages whose signing imports were commented out and applies the same policy to the newer Uno packages.
Root cause
Svg.Skia already keeps a strong-name key and central
build/SignAssembly.propssettings, and most packages import them. Five packable projects did not:Skia.Controls.AvaloniaSvg.Controls.AvaloniaSvg.Controls.Skia.AvaloniaSvg.Controls.Skia.UnoSvgML.UnoThe Uno control also exposes internals to its test assembly. Once the production assembly is signed, .NET requires that friend assembly declaration to include the full public key and that the test assembly be signed with the matching key.
Changes
Svg.Controls.Skia.Uno.UnitTestswith the same repository keyInternalsVisibleTodeclaration with the matching public keyAll affected assemblies now use public key token
dafe96fe6c845a74, consistent with the rest of the package family.This addresses strong-name assembly signing, matching the request and prior #19 implementation. It does not add Authenticode publisher signing, which would require a separately managed trusted code-signing certificate.
Impact
Consumers that require strong-named dependencies can use the Avalonia and Uno packages without encountering unsigned Svg.Skia assemblies. The change also makes assembly identity consistent across the complete first-party package set.
Validation
dotnet format Svg.Skia.slnx --no-restoredotnet build Svg.Skia.slnx -c Release --no-restoredotnet test Svg.Skia.slnx -c Release --no-restoresn -Tandsn -vfFixes #535