Complete remaining standards roadmap slices#539
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dc299165d0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fb7ec23547
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7a4ecd4d65
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f315eb376a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e73c8e2808
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8480146d41
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a558b4950e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0ca576729c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 56cc73966e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Svg.Skia/src/Svg.Skia/SkiaSvgAssetLoader.cs
Lines 233 to 235 in e6c7877
When an embedded @font-face uses a CSS family name that differs from the font's internal family, this conversion drops the family override that FindTypefaces just attached to the span. Since span candidates are now tried before the preferred/platform candidates, FindRunTypeface can return a shim named after the internal family; the later ToSKTextPaint lookup won't match DocumentFontTypefaceProvider (which is keyed by the CSS font-family), so browser-compatible full-run paths such as RTL or emoji/cursive text render with fallback fonts instead of the document font. Keep the span's shim family, or carry the override through when returning the run typeface.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Addressed the latest Codex review about preserving @font-face family names for run typefaces in Details:
Validation:
The full local |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bb8d48efe9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Follow-up pushed in The original fix preserved the span shim family, but it also changed provider family-token matching on the per-codepoint fallback path. That broader scan was unnecessary for the review issue and matched the long local/macOS CI runtime. The follow-up restores the existing per-codepoint provider matching behavior and only resolves a concrete CSS family token for multi-family run candidates inside Validation after the follow-up:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1a9d217de6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
CI compatibility follow-up pushed in The failed Build/Docs jobs on Validation before push:
No |
Complete Remaining Standards Roadmap Slices
Summary
This PR completes the current remaining standards-test roadmap slices and converts the broad skipped-test debt into explicit, tracked policy or feature-area inventory.
The branch promotes the available W3C rows for mixed-script text baselines, WOFF-backed document fonts, deterministic system colors, and legacy
animateColorsemantics. It also keeps the browser UI and recursive capture cases as explicit policy skips with semantic coverage, replaces the broad resvg non-text umbrella skip with feature-area inventories, and updates the roadmap with the true remaining work.Main Changes
DrawTextordering.@font-faceloading for W3C WOFF resources, including WOFF-to-SFNT conversion, document typeface providers, font cache invalidation, and HTTP capture script font MIME/fallback support.animateColorpolicy so direct SVG 1.1 color interpolation is supported while inherited paint-server color state indefsremains browser-stable.<use>suppression rather than manufacturing browser UI baselines.W3C Status
After this branch, the W3C suite result is:
The remaining W3C skips are now explicit:
struct-image-12-b: Chrome native broken-image UI policy.struct-use-08-b: Chrome recursive capture never reaches a stable baseline.text-fonts-06-t: fixture is missing from the bundled W3C checkout.Promoted rows include:
text-align-08-bpservers-grad-08-brender-elems-06-trender-elems-07-trender-elems-08-trender-groups-01-brender-groups-03-tanimate-elem-23-tanimate-elem-84-tanimate-elem-85-tcolor-prof-01-fcolor-prop-04-tresvg Status
The former broad
non_text_fixturesskip is replaced by explicit remaining feature-area theories:remaining_extra_fixtures: 15 rowsremaining_filter_fixtures: 281 rowsremaining_masking_fixtures: 92 rowsremaining_paint_server_fixtures: 148 rowsremaining_painting_fixtures: 115 rowsremaining_shape_fixtures: 69 rowsremaining_structure_fixtures: 165 rowsThe inventory guardrails assert the total fixture accounting so future slices can enable feature areas without reintroducing broad hardening buckets.
Validation
Completed before publishing this PR:
dotnet format Svg.Skia.slnx --no-restore --verify-no-changes --include <changed C# files>passed.dotnet format Svg.Skia.slnx --no-restore --verify-no-changeswas also run and still reports pre-existing formatting/encoding issues underexternals/SVG.dotnet build Svg.Skia.slnx -c Release --no-restorepassed.dotnet test tests/Svg.Skia.UnitTests/Svg.Skia.UnitTests.csproj -f net10.0 -c Release --no-build --filter "FullyQualifiedName~W3CTestSuiteTests.Tests"passed with523 passed / 3 skipped / 526 total.dotnet test Svg.Skia.slnx -c Release --no-buildpassed.Remaining Work After This PR
text-fonts-06-t.struct-image-12-bandstruct-use-08-bas explicit policy skips unless browser UI or recursive capture visual emulation becomes a product requirement.