Fix strong name signing: remove OS-conditional PublicSign#480
Merged
wieslawsoltes merged 1 commit intoApr 7, 2026
Merged
Conversation
…T Framework The PublicSign condition `'$(OS)' != 'Windows_NT'` causes assemblies built on Linux (GitHub Actions CI) to be public-signed only, without a real RSA signature. This breaks strong name verification on .NET Framework 4.x, which unlike .NET Core/5+ enforces signature validation at runtime. Since svg.skia.public.snk contains a full RSA key pair (596 bytes), real signing works on all platforms with modern .NET SDK without needing PublicSign. Fixes wieslawsoltes#479 Made-with: Cursor
Owner
|
@codex full review |
|
Codex Review: Didn't find any major issues. 🚀 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This was referenced Apr 9, 2026
This was referenced Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the OS-conditional
PublicSignfrombuild/SignAssembly.propsto fix strong name validation failures on .NET Framework 4.x.Problem
Since v3.3.0, when the CI was moved from Azure Pipelines (
windows-2022) to GitHub Actions (ubuntu-latest), thePublicSigncondition inSignAssembly.propsactivates on Linux:This causes the
net461assemblies (ShimSkiaSharp, Svg.Custom, Svg.Model, Svg.Skia) to be public-signed only — no real RSA signature is produced. .NET Core/5+ ignores this since it skips strong name verification entirely, but .NET Framework 4.x enforces verification and throwsFileLoadExceptionat runtime:Verified with
sn.exe -vf: all versions from 3.3.0 through 4.0.0-rc1 fail; 3.2.1 and earlier pass.Fix
Remove the
<PublicSign>line. Sincesvg.skia.public.snkcontains a full 596-byte RSA key pair (not just the public key), the .NET SDK can produce real signatures on all platforms — Windows, Linux, and macOS — without needingPublicSign.Fixes #479